-
Notifications
You must be signed in to change notification settings - Fork 475
Revert "perf(debugger): reduce code origin startup time (#15272)" [backport 4.1] #15777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
5843f45 to
908336b
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 2 ms. The average import time from base is: 254 ± 2 ms. The import time difference between this PR and base is: -3.01 ± 0.1 ms. Import time breakdownThe following import paths have appeared:
|
Performance SLOsComparing candidate backport-15776-to-4.1 (908336b) with baseline 4.1 (1d9cfeb) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.115µs (SLO: <20.000µs -9.4%) vs baseline: 📈 +21.2% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 14.970µs (SLO: <20.000µs 📉 -25.2%) vs baseline: +0.7% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.6% ✅ add_inplace_noaspectTime: ✅ 0.338µs (SLO: <10.000µs 📉 -96.6%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ add_noaspectTime: ✅ 0.548µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +0.3% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.0% ✅ bytearray_aspectTime: ✅ 17.980µs (SLO: <30.000µs 📉 -40.1%) vs baseline: -0.4% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 23.708µs (SLO: <30.000µs 📉 -21.0%) vs baseline: +0.2% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ bytearray_extend_noaspectTime: ✅ 2.658µs (SLO: <10.000µs 📉 -73.4%) vs baseline: +0.2% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 1.460µs (SLO: <10.000µs 📉 -85.4%) vs baseline: +0.7% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 16.754µs (SLO: <20.000µs 📉 -16.2%) vs baseline: +0.2% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 1.395µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -0.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 55.160µs (SLO: <70.000µs 📉 -21.2%) vs baseline: +0.2% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.3% ✅ bytesio_noaspectTime: ✅ 3.194µs (SLO: <10.000µs 📉 -68.1%) vs baseline: -0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ capitalize_aspectTime: ✅ 14.610µs (SLO: <20.000µs 📉 -26.9%) vs baseline: -0.6% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ capitalize_noaspectTime: ✅ 2.546µs (SLO: <10.000µs 📉 -74.5%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.3% ✅ casefold_aspectTime: ✅ 14.651µs (SLO: <20.000µs 📉 -26.7%) vs baseline: -0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.2% ✅ casefold_noaspectTime: ✅ 3.079µs (SLO: <10.000µs 📉 -69.2%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 15.611µs (SLO: <30.000µs 📉 -48.0%) vs baseline: +0.6% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 1.578µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -0.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 18.213µs (SLO: <30.000µs 📉 -39.3%) vs baseline: 📈 +22.3% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 1.468µs (SLO: <10.000µs 📉 -85.3%) vs baseline: +1.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 171.311µs (SLO: <200.000µs 📉 -14.3%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 192.193µs (SLO: <200.000µs -3.9%) vs baseline: +0.3% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 3.714µs (SLO: <10.000µs 📉 -62.9%) vs baseline: -0.5% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.7% ✅ format_noaspectTime: ✅ 3.158µs (SLO: <10.000µs 📉 -68.4%) vs baseline: -0.2% Memory: ✅ 42.841MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +5.5% ✅ index_aspectTime: ✅ 15.140µs (SLO: <20.000µs 📉 -24.3%) vs baseline: -1.3% Memory: ✅ 42.841MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 16.925µs (SLO: <20.000µs 📉 -15.4%) vs baseline: -0.1% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.3% ✅ join_noaspectTime: ✅ 1.510µs (SLO: <10.000µs 📉 -84.9%) vs baseline: +1.8% Memory: ✅ 42.723MB (SLO: <43.250MB 🟡 -1.2%) vs baseline: +4.3% ✅ ljust_aspectTime: ✅ 20.857µs (SLO: <30.000µs 📉 -30.5%) vs baseline: +0.4% Memory: ✅ 42.743MB (SLO: <43.250MB 🟡 -1.2%) vs baseline: +4.6% ✅ ljust_noaspectTime: ✅ 2.675µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +0.7% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.5% ✅ lower_aspectTime: ✅ 17.796µs (SLO: <30.000µs 📉 -40.7%) vs baseline: -0.4% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ lower_noaspectTime: ✅ 2.375µs (SLO: <10.000µs 📉 -76.3%) vs baseline: -2.1% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 17.580µs (SLO: <20.000µs 📉 -12.1%) vs baseline: -0.1% Memory: ✅ 42.998MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 1.823µs (SLO: <10.000µs 📉 -81.8%) vs baseline: -1.0% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.4% ✅ modulo_aspectTime: ✅ 166.669µs (SLO: <200.000µs 📉 -16.7%) vs baseline: +0.3% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.476µs (SLO: <200.000µs 📉 -12.8%) vs baseline: ~same Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.3% ✅ modulo_aspect_for_bytesTime: ✅ 167.967µs (SLO: <200.000µs 📉 -16.0%) vs baseline: ~same Memory: ✅ 43.195MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.973µs (SLO: <200.000µs 📉 -14.0%) vs baseline: ~same Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.2% ✅ modulo_noaspectTime: ✅ 3.781µs (SLO: <10.000µs 📉 -62.2%) vs baseline: +2.7% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 214.807µs (SLO: <300.000µs 📉 -28.4%) vs baseline: -0.2% Memory: ✅ 42.880MB (SLO: <44.000MB -2.5%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 5.179µs (SLO: <10.000µs 📉 -48.2%) vs baseline: +0.2% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 1.385µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.4% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.4% ✅ repr_noaspectTime: ✅ 0.528µs (SLO: <10.000µs 📉 -94.7%) vs baseline: +0.7% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.5% ✅ rstrip_aspectTime: ✅ 19.067µs (SLO: <30.000µs 📉 -36.4%) vs baseline: -0.2% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 1.917µs (SLO: <10.000µs 📉 -80.8%) vs baseline: +2.1% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 15.921µs (SLO: <20.000µs 📉 -20.4%) vs baseline: -0.4% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.3% ✅ slice_noaspectTime: ✅ 0.595µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.8% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 53.850µs (SLO: <80.000µs 📉 -32.7%) vs baseline: +0.4% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 3.517µs (SLO: <10.000µs 📉 -64.8%) vs baseline: ~same Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +5.5% ✅ strip_aspectTime: ✅ 17.676µs (SLO: <20.000µs 📉 -11.6%) vs baseline: +0.2% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 1.817µs (SLO: <10.000µs 📉 -81.8%) vs baseline: -0.8% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 18.327µs (SLO: <30.000µs 📉 -38.9%) vs baseline: -0.2% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 2.775µs (SLO: <10.000µs 📉 -72.3%) vs baseline: +1.1% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 21.822µs (SLO: <30.000µs 📉 -27.3%) vs baseline: 📈 +20.0% Memory: ✅ 42.841MB (SLO: <43.000MB 🟡 -0.4%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 2.645µs (SLO: <10.000µs 📉 -73.6%) vs baseline: ~same Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 20.313µs (SLO: <30.000µs 📉 -32.3%) vs baseline: ~same Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ translate_noaspectTime: ✅ 4.241µs (SLO: <10.000µs 📉 -57.6%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.5% ✅ upper_aspectTime: ✅ 17.751µs (SLO: <30.000µs 📉 -40.8%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.2% ✅ upper_noaspectTime: ✅ 2.387µs (SLO: <10.000µs 📉 -76.1%) vs baseline: +0.6% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.287µs (SLO: <10.000µs 📉 -47.1%) vs baseline: 📈 +21.8% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 4.418µs (SLO: <10.000µs 📉 -55.8%) vs baseline: -0.5% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.221µs (SLO: <10.000µs 📉 -37.8%) vs baseline: -0.9% Memory: ✅ 41.543MB (SLO: <43.500MB -4.5%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 6.302µs (SLO: <10.000µs 📉 -37.0%) vs baseline: +0.2% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.614µs (SLO: <10.000µs 📉 -63.9%) vs baseline: -0.2% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 3.696µs (SLO: <10.000µs 📉 -63.0%) vs baseline: +0.1% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.955µs (SLO: <10.000µs 📉 -50.4%) vs baseline: -0.8% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 5.062µs (SLO: <10.000µs 📉 -49.4%) vs baseline: -0.4% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.826µs (SLO: <10.000µs 📉 -61.7%) vs baseline: -0.6% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.745µs (SLO: <10.000µs 📉 -92.5%) vs baseline: ~same Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.719µs (SLO: <10.000µs 📉 -52.8%) vs baseline: -0.1% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 4.760µs (SLO: <10.000µs 📉 -52.4%) vs baseline: +0.3% Memory: ✅ 41.524MB (SLO: <43.500MB -4.5%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.370µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +11.4% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 200.532µs (SLO: <220.000µs -8.8%) vs baseline: -0.9% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.386µs (SLO: <20.000µs 📉 -83.1%) vs baseline: +0.1% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.476µs (SLO: <230.000µs -5.4%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.205µs (SLO: <20.000µs 📉 -89.0%) vs baseline: ~same Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.073µs (SLO: <150.000µs -8.6%) vs baseline: +0.7% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.158µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +0.1% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-rate-metrics-100-timesTime: ✅ 214.705µs (SLO: <250.000µs 📉 -14.1%) vs baseline: +0.3% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.110ms (SLO: <22.000ms -8.6%) vs baseline: -0.8% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.269ms (SLO: <2.550ms 📉 -11.0%) vs baseline: +0.3% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.405ms (SLO: <1.550ms -9.3%) vs baseline: -0.5% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.197ms (SLO: <2.550ms 📉 -13.9%) vs baseline: -0.2% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.4% ✅ flush-1-metricTime: ✅ 4.668µs (SLO: <20.000µs 📉 -76.7%) vs baseline: -0.1% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 175.029µs (SLO: <250.000µs 📉 -30.0%) vs baseline: -0.1% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.173ms (SLO: <2.500ms 📉 -13.1%) vs baseline: +0.3% Memory: ✅ 36.038MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +5.0% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Backport 5d83367 from #15776 to 4.1.
This reverts commit #15272
We detected errors " Context already registered" that we believe related to PR #15272.
So we undo this change and backport the fix.