-
Notifications
You must be signed in to change notification settings - Fork 475
fix(crashtracking): only inherit crashtracker specific ENV vars for CT receiver #15775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Performance SLOsComparing candidate gyuheon0h/4.1-dual-upload (08e755b) with baseline main (2c1aa02) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.042µs (SLO: <20.000µs -9.8%) vs baseline: 📈 +21.2% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ add_inplace_aspectTime: ✅ 15.050µs (SLO: <20.000µs 📉 -24.8%) vs baseline: +1.0% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.342µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +1.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.545µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -1.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ bytearray_aspectTime: ✅ 18.032µs (SLO: <30.000µs 📉 -39.9%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 23.847µs (SLO: <30.000µs 📉 -20.5%) vs baseline: ~same Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ bytearray_extend_noaspectTime: ✅ 2.741µs (SLO: <10.000µs 📉 -72.6%) vs baseline: -1.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 1.477µs (SLO: <10.000µs 📉 -85.2%) vs baseline: +0.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 16.695µs (SLO: <20.000µs 📉 -16.5%) vs baseline: +0.4% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 1.416µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.9% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 55.333µs (SLO: <70.000µs 📉 -21.0%) vs baseline: -0.4% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 3.294µs (SLO: <10.000µs 📉 -67.1%) vs baseline: +0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 14.683µs (SLO: <20.000µs 📉 -26.6%) vs baseline: +0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 2.581µs (SLO: <10.000µs 📉 -74.2%) vs baseline: ~same Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 14.549µs (SLO: <20.000µs 📉 -27.3%) vs baseline: -0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ casefold_noaspectTime: ✅ 3.156µs (SLO: <10.000µs 📉 -68.4%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 15.618µs (SLO: <30.000µs 📉 -47.9%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 1.600µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 18.159µs (SLO: <30.000µs 📉 -39.5%) vs baseline: 📈 +23.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ encode_noaspectTime: ✅ 1.483µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -1.7% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ format_aspectTime: ✅ 170.877µs (SLO: <200.000µs 📉 -14.6%) vs baseline: -0.1% Memory: ✅ 42.821MB (SLO: <43.250MB 🟡 -1.0%) vs baseline: +5.0% ✅ format_map_aspectTime: ✅ 190.674µs (SLO: <200.000µs -4.7%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 3.818µs (SLO: <10.000µs 📉 -61.8%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 3.145µs (SLO: <10.000µs 📉 -68.5%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 15.355µs (SLO: <20.000µs 📉 -23.2%) vs baseline: -0.1% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.466µs (SLO: <10.000µs 📉 -95.3%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 17.004µs (SLO: <20.000µs 📉 -15.0%) vs baseline: -0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 1.561µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +0.6% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 20.895µs (SLO: <30.000µs 📉 -30.4%) vs baseline: +1.1% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ ljust_noaspectTime: ✅ 2.724µs (SLO: <10.000µs 📉 -72.8%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 17.875µs (SLO: <30.000µs 📉 -40.4%) vs baseline: +0.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 2.426µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +0.9% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 17.651µs (SLO: <30.000µs 📉 -41.2%) vs baseline: -0.4% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 1.856µs (SLO: <10.000µs 📉 -81.4%) vs baseline: -1.5% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.2% ✅ modulo_aspectTime: ✅ 166.324µs (SLO: <200.000µs 📉 -16.8%) vs baseline: +0.2% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 179.891µs (SLO: <200.000µs 📉 -10.1%) vs baseline: +3.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 168.593µs (SLO: <200.000µs 📉 -15.7%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.094µs (SLO: <200.000µs 📉 -14.0%) vs baseline: +0.4% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 3.684µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +0.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 212.081µs (SLO: <300.000µs 📉 -29.3%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <44.000MB -2.9%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 2.900µs (SLO: <10.000µs 📉 -71.0%) vs baseline: ~same Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 1.419µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.529µs (SLO: <10.000µs 📉 -94.7%) vs baseline: +1.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ rstrip_aspectTime: ✅ 19.034µs (SLO: <30.000µs 📉 -36.6%) vs baseline: +0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 2.040µs (SLO: <10.000µs 📉 -79.6%) vs baseline: +6.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ slice_aspectTime: ✅ 15.885µs (SLO: <20.000µs 📉 -20.6%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 0.598µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.4% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 53.858µs (SLO: <80.000µs 📉 -32.7%) vs baseline: -1.1% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ stringio_noaspectTime: ✅ 3.623µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -0.8% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 17.725µs (SLO: <20.000µs 📉 -11.4%) vs baseline: +0.6% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 1.864µs (SLO: <10.000µs 📉 -81.4%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 18.471µs (SLO: <30.000µs 📉 -38.4%) vs baseline: -0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 2.789µs (SLO: <10.000µs 📉 -72.1%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 18.275µs (SLO: <30.000µs 📉 -39.1%) vs baseline: +0.7% Memory: ✅ 42.526MB (SLO: <43.000MB 🟡 -1.1%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 2.680µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +1.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 24.331µs (SLO: <30.000µs 📉 -18.9%) vs baseline: 📈 +18.8% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 4.318µs (SLO: <10.000µs 📉 -56.8%) vs baseline: +0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 17.963µs (SLO: <30.000µs 📉 -40.1%) vs baseline: -0.1% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.2% ✅ upper_noaspectTime: ✅ 2.446µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.181µs (SLO: <10.000µs 📉 -48.2%) vs baseline: 📈 +22.9% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 4.342µs (SLO: <10.000µs 📉 -56.6%) vs baseline: +0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.216µs (SLO: <10.000µs 📉 -37.8%) vs baseline: -0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ ospathjoin_noaspectTime: ✅ 6.316µs (SLO: <10.000µs 📉 -36.8%) vs baseline: +0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.573µs (SLO: <10.000µs 📉 -64.3%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 3.705µs (SLO: <10.000µs 📉 -63.0%) vs baseline: +2.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.930µs (SLO: <10.000µs 📉 -50.7%) vs baseline: +0.6% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 5.004µs (SLO: <10.000µs 📉 -50.0%) vs baseline: +0.1% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.5% ✅ ospathsplitdrive_aspectTime: ✅ 3.770µs (SLO: <10.000µs 📉 -62.3%) vs baseline: +1.0% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.5% ✅ ospathsplitdrive_noaspectTime: ✅ 0.749µs (SLO: <10.000µs 📉 -92.5%) vs baseline: +1.0% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.627µs (SLO: <10.000µs 📉 -53.7%) vs baseline: -0.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 4.653µs (SLO: <10.000µs 📉 -53.5%) vs baseline: +0.9% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.420µs (SLO: <20.000µs 📉 -82.9%) vs baseline: 📈 +14.3% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.4% ✅ 1-count-metrics-100-timesTime: ✅ 201.730µs (SLO: <220.000µs -8.3%) vs baseline: +0.8% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.371µs (SLO: <20.000µs 📉 -83.1%) vs baseline: +1.9% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.204µs (SLO: <230.000µs -6.4%) vs baseline: +1.0% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.242µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +0.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.180µs (SLO: <150.000µs -9.2%) vs baseline: -0.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.164µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +0.6% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 215.655µs (SLO: <250.000µs 📉 -13.7%) vs baseline: +1.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.078ms (SLO: <22.000ms -8.7%) vs baseline: +0.9% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.213ms (SLO: <2.550ms 📉 -13.2%) vs baseline: -0.5% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.416ms (SLO: <1.550ms -8.6%) vs baseline: +0.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.183ms (SLO: <2.550ms 📉 -14.4%) vs baseline: +0.3% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 4.598µs (SLO: <20.000µs 📉 -77.0%) vs baseline: -0.3% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.350µs (SLO: <250.000µs 📉 -30.3%) vs baseline: ~same Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.8% ✅ flush-1000-metricsTime: ✅ 2.177ms (SLO: <2.500ms 📉 -12.9%) vs baseline: ~same Memory: ✅ 36.038MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +4.6% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
Tests failed on this commit d9ea5c7: What to do next?
|
GianlucaBortoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Codeowners resolved as |
Description
Inheriting all env vars causes conflicts with Crashtracker uploader logic. We should only inherit specific crashtracker ones.
Testing
Risks
Additional Notes