-
Notifications
You must be signed in to change notification settings - Fork 475
ci(iast): fix flaky benchmark test #15756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Performance SLOsComparing candidate avara1986/APPSEC-60297_reduce_flakyness_2 (5cecc76) with baseline main (f748494) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 17.949µs (SLO: <20.000µs 📉 -10.3%) vs baseline: 📈 +20.8% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 14.874µs (SLO: <20.000µs 📉 -25.6%) vs baseline: -0.8% Memory: ✅ 42.920MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.6% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +0.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.548µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +0.6% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 18.061µs (SLO: <30.000µs 📉 -39.8%) vs baseline: +0.1% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 23.995µs (SLO: <30.000µs 📉 -20.0%) vs baseline: +0.2% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.5% ✅ bytearray_extend_noaspectTime: ✅ 2.739µs (SLO: <10.000µs 📉 -72.6%) vs baseline: -0.6% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 1.484µs (SLO: <10.000µs 📉 -85.2%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 16.703µs (SLO: <20.000µs 📉 -16.5%) vs baseline: +0.6% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 1.429µs (SLO: <10.000µs 📉 -85.7%) vs baseline: -0.6% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 55.364µs (SLO: <70.000µs 📉 -20.9%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 3.296µs (SLO: <10.000µs 📉 -67.0%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 14.732µs (SLO: <20.000µs 📉 -26.3%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 2.609µs (SLO: <10.000µs 📉 -73.9%) vs baseline: +1.0% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ casefold_aspectTime: ✅ 14.684µs (SLO: <20.000µs 📉 -26.6%) vs baseline: +0.2% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 3.180µs (SLO: <10.000µs 📉 -68.2%) vs baseline: +1.2% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 15.615µs (SLO: <30.000µs 📉 -47.9%) vs baseline: +0.9% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.7% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 18.127µs (SLO: <30.000µs 📉 -39.6%) vs baseline: 📈 +22.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 1.506µs (SLO: <10.000µs 📉 -84.9%) vs baseline: +0.7% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 171.117µs (SLO: <200.000µs 📉 -14.4%) vs baseline: ~same Memory: ✅ 43.254MB (SLO: <43.250MB ~same) vs baseline: +5.2% ✅ format_map_aspectTime: ✅ 190.580µs (SLO: <200.000µs -4.7%) vs baseline: ~same Memory: ✅ 43.254MB (SLO: <43.500MB 🟡 -0.6%) vs baseline: +5.2% ✅ format_map_noaspectTime: ✅ 3.792µs (SLO: <10.000µs 📉 -62.1%) vs baseline: -0.8% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 3.148µs (SLO: <10.000µs 📉 -68.5%) vs baseline: -0.2% Memory: ✅ 42.959MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.8% ✅ index_aspectTime: ✅ 15.303µs (SLO: <20.000µs 📉 -23.5%) vs baseline: ~same Memory: ✅ 42.900MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.7% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ join_aspectTime: ✅ 17.014µs (SLO: <20.000µs 📉 -14.9%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 1.571µs (SLO: <10.000µs 📉 -84.3%) vs baseline: +1.3% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 20.773µs (SLO: <30.000µs 📉 -30.8%) vs baseline: -0.4% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 2.695µs (SLO: <10.000µs 📉 -73.0%) vs baseline: -1.5% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 17.969µs (SLO: <30.000µs 📉 -40.1%) vs baseline: -0.1% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 2.417µs (SLO: <10.000µs 📉 -75.8%) vs baseline: -0.2% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 17.634µs (SLO: <30.000µs 📉 -41.2%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.6% ✅ lstrip_noaspectTime: ✅ 1.878µs (SLO: <10.000µs 📉 -81.2%) vs baseline: -0.3% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ modulo_aspectTime: ✅ 166.100µs (SLO: <200.000µs 📉 -17.0%) vs baseline: ~same Memory: ✅ 43.175MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.577µs (SLO: <200.000µs 📉 -12.7%) vs baseline: ~same Memory: ✅ 43.195MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +5.2% ✅ modulo_aspect_for_bytesTime: ✅ 168.554µs (SLO: <200.000µs 📉 -15.7%) vs baseline: ~same Memory: ✅ 43.155MB (SLO: <43.500MB 🟡 -0.8%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.745µs (SLO: <200.000µs 📉 -14.1%) vs baseline: -0.1% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 3.668µs (SLO: <10.000µs 📉 -63.3%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 220.187µs (SLO: <300.000µs 📉 -26.6%) vs baseline: +3.8% Memory: ✅ 43.057MB (SLO: <44.000MB -2.1%) vs baseline: +4.5% ✅ replace_noaspectTime: ✅ 2.906µs (SLO: <10.000µs 📉 -70.9%) vs baseline: -0.6% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 1.416µs (SLO: <10.000µs 📉 -85.8%) vs baseline: -0.5% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.524µs (SLO: <10.000µs 📉 -94.8%) vs baseline: -0.2% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 22.889µs (SLO: <30.000µs 📉 -23.7%) vs baseline: 📈 +20.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 1.928µs (SLO: <10.000µs 📉 -80.7%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 15.864µs (SLO: <20.000µs 📉 -20.7%) vs baseline: +0.1% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 54.009µs (SLO: <80.000µs 📉 -32.5%) vs baseline: +0.6% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ stringio_noaspectTime: ✅ 3.669µs (SLO: <10.000µs 📉 -63.3%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 17.620µs (SLO: <20.000µs 📉 -11.9%) vs baseline: -0.5% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ strip_noaspectTime: ✅ 1.861µs (SLO: <10.000µs 📉 -81.4%) vs baseline: -0.9% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 18.461µs (SLO: <30.000µs 📉 -38.5%) vs baseline: -0.3% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 2.783µs (SLO: <10.000µs 📉 -72.2%) vs baseline: -1.2% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 18.369µs (SLO: <30.000µs 📉 -38.8%) vs baseline: +0.6% Memory: ✅ 43.037MB (SLO: <43.000MB ~same) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 2.868µs (SLO: <10.000µs 📉 -71.3%) vs baseline: +7.2% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 20.405µs (SLO: <30.000µs 📉 -32.0%) vs baseline: -0.3% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 4.304µs (SLO: <10.000µs 📉 -57.0%) vs baseline: -1.0% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 17.857µs (SLO: <30.000µs 📉 -40.5%) vs baseline: +0.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 2.428µs (SLO: <10.000µs 📉 -75.7%) vs baseline: -0.8% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.120µs (SLO: <10.000µs 📉 -48.8%) vs baseline: 📈 +20.7% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 4.319µs (SLO: <10.000µs 📉 -56.8%) vs baseline: +0.6% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.257µs (SLO: <10.000µs 📉 -37.4%) vs baseline: ~same Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 6.321µs (SLO: <10.000µs 📉 -36.8%) vs baseline: +0.5% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.579µs (SLO: <10.000µs 📉 -64.2%) vs baseline: +0.5% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 3.631µs (SLO: <10.000µs 📉 -63.7%) vs baseline: -0.8% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.884µs (SLO: <10.000µs 📉 -51.2%) vs baseline: -0.8% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 4.957µs (SLO: <10.000µs 📉 -50.4%) vs baseline: -0.4% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.748µs (SLO: <10.000µs 📉 -62.5%) vs baseline: +0.2% Memory: ✅ 41.524MB (SLO: <43.500MB -4.5%) vs baseline: +5.2% ✅ ospathsplitdrive_noaspectTime: ✅ 0.745µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -1.0% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.627µs (SLO: <10.000µs 📉 -53.7%) vs baseline: -0.2% Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 4.622µs (SLO: <10.000µs 📉 -53.8%) vs baseline: -0.8% Memory: ✅ 41.543MB (SLO: <43.500MB -4.5%) vs baseline: +5.3% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.395µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +14.5% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.5% ✅ 1-count-metrics-100-timesTime: ✅ 201.296µs (SLO: <220.000µs -8.5%) vs baseline: +1.3% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.323µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.2% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.984µs (SLO: <230.000µs -5.7%) vs baseline: +1.2% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.203µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +0.6% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.951µs (SLO: <150.000µs -8.7%) vs baseline: +0.2% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.148µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +0.7% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 213.368µs (SLO: <250.000µs 📉 -14.7%) vs baseline: +0.5% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 19.907ms (SLO: <22.000ms -9.5%) vs baseline: +0.1% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.261ms (SLO: <2.550ms 📉 -11.3%) vs baseline: +1.0% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.2%) vs baseline: +0.5% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.210ms (SLO: <2.550ms 📉 -13.3%) vs baseline: +0.8% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.598µs (SLO: <20.000µs 📉 -77.0%) vs baseline: -0.5% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.155µs (SLO: <250.000µs 📉 -30.3%) vs baseline: +0.2% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.4% ✅ flush-1000-metricsTime: ✅ 2.161ms (SLO: <2.500ms 📉 -13.6%) vs baseline: -0.3% Memory: ✅ 36.058MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +5.0% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Fix flakyness in `lstrip_aspect` https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1310950874 (cherry picked from commit 2484164)
Fix flakyness in `lstrip_aspect` https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1310950874 (cherry picked from commit 2484164) Signed-off-by: Alberto Vara <[email protected]>
Fix flakyness in
lstrip_aspecthttps://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1310950874