-
Notifications
You must be signed in to change notification settings - Fork 475
feat(appsec): automated business logic events for payments #15727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
4423174 to
eb417b5
Compare
Performance SLOsComparing candidate florentin.labelle/APPSEC-60157/stripe (4c3f9d2) with baseline main (390118c) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.104µs (SLO: <20.000µs -9.5%) vs baseline: 📈 +22.6% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.0% ✅ add_inplace_aspectTime: ✅ 14.883µs (SLO: <20.000µs 📉 -25.6%) vs baseline: +0.3% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +3.7% ✅ add_inplace_noaspectTime: ✅ 0.339µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.8% ✅ add_noaspectTime: ✅ 0.546µs (SLO: <10.000µs 📉 -94.5%) vs baseline: ~same Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +3.8% ✅ bytearray_aspectTime: ✅ 18.051µs (SLO: <30.000µs 📉 -39.8%) vs baseline: +0.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.0% ✅ bytearray_extend_aspectTime: ✅ 24.069µs (SLO: <30.000µs 📉 -19.8%) vs baseline: +0.6% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.1% ✅ bytearray_extend_noaspectTime: ✅ 2.708µs (SLO: <10.000µs 📉 -72.9%) vs baseline: -2.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.7% ✅ bytearray_noaspectTime: ✅ 1.479µs (SLO: <10.000µs 📉 -85.2%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.8% ✅ bytes_aspectTime: ✅ 16.769µs (SLO: <20.000µs 📉 -16.2%) vs baseline: +1.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +3.9% ✅ bytes_noaspectTime: ✅ 1.436µs (SLO: <10.000µs 📉 -85.6%) vs baseline: +1.8% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ bytesio_aspectTime: ✅ 56.038µs (SLO: <70.000µs 📉 -19.9%) vs baseline: +1.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.7% ✅ bytesio_noaspectTime: ✅ 3.264µs (SLO: <10.000µs 📉 -67.4%) vs baseline: -0.6% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ capitalize_aspectTime: ✅ 14.794µs (SLO: <20.000µs 📉 -26.0%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ capitalize_noaspectTime: ✅ 2.578µs (SLO: <10.000µs 📉 -74.2%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.0% ✅ casefold_aspectTime: ✅ 14.808µs (SLO: <20.000µs 📉 -26.0%) vs baseline: +0.7% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +3.8% ✅ casefold_noaspectTime: ✅ 3.186µs (SLO: <10.000µs 📉 -68.1%) vs baseline: +0.8% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.0% ✅ decode_aspectTime: ✅ 15.707µs (SLO: <30.000µs 📉 -47.6%) vs baseline: +0.7% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +3.9% ✅ decode_noaspectTime: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.8% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +3.9% ✅ encode_aspectTime: ✅ 18.285µs (SLO: <30.000µs 📉 -39.1%) vs baseline: 📈 +23.8% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.7% ✅ encode_noaspectTime: ✅ 1.492µs (SLO: <10.000µs 📉 -85.1%) vs baseline: +0.3% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.4% ✅ format_aspectTime: ✅ 171.205µs (SLO: <200.000µs 📉 -14.4%) vs baseline: +0.1% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +3.3% ✅ format_map_aspectTime: ✅ 191.362µs (SLO: <200.000µs -4.3%) vs baseline: +0.1% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +3.5% ✅ format_map_noaspectTime: ✅ 3.783µs (SLO: <10.000µs 📉 -62.2%) vs baseline: -0.6% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +3.9% ✅ format_noaspectTime: ✅ 3.153µs (SLO: <10.000µs 📉 -68.5%) vs baseline: -0.9% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +3.8% ✅ index_aspectTime: ✅ 15.432µs (SLO: <20.000µs 📉 -22.8%) vs baseline: +1.1% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +3.9% ✅ index_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.1% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +3.6% ✅ join_aspectTime: ✅ 17.023µs (SLO: <20.000µs 📉 -14.9%) vs baseline: -0.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.0% ✅ join_noaspectTime: ✅ 1.548µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -1.1% Memory: ✅ 42.684MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +4.2% ✅ ljust_aspectTime: ✅ 20.906µs (SLO: <30.000µs 📉 -30.3%) vs baseline: +0.5% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +3.6% ✅ ljust_noaspectTime: ✅ 2.706µs (SLO: <10.000µs 📉 -72.9%) vs baseline: +0.3% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +3.7% ✅ lower_aspectTime: ✅ 17.935µs (SLO: <30.000µs 📉 -40.2%) vs baseline: +0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ lower_noaspectTime: ✅ 2.412µs (SLO: <10.000µs 📉 -75.9%) vs baseline: -1.1% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +3.9% ✅ lstrip_aspectTime: ✅ 21.884µs (SLO: <30.000µs 📉 -27.1%) vs baseline: 📈 +24.3% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +3.9% ✅ lstrip_noaspectTime: ✅ 1.858µs (SLO: <10.000µs 📉 -81.4%) vs baseline: -0.2% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +3.7% ✅ modulo_aspectTime: ✅ 166.576µs (SLO: <200.000µs 📉 -16.7%) vs baseline: +0.4% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +3.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.983µs (SLO: <200.000µs 📉 -12.5%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +3.7% ✅ modulo_aspect_for_bytesTime: ✅ 168.609µs (SLO: <200.000µs 📉 -15.7%) vs baseline: ~same Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +3.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.466µs (SLO: <200.000µs 📉 -13.8%) vs baseline: +0.1% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.0% ✅ modulo_noaspectTime: ✅ 3.695µs (SLO: <10.000µs 📉 -63.0%) vs baseline: +0.7% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +3.8% ✅ replace_aspectTime: ✅ 212.215µs (SLO: <300.000µs 📉 -29.3%) vs baseline: +0.2% Memory: ✅ 42.723MB (SLO: <44.000MB -2.9%) vs baseline: +4.1% ✅ replace_noaspectTime: ✅ 2.904µs (SLO: <10.000µs 📉 -71.0%) vs baseline: +0.5% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ repr_aspectTime: ✅ 1.477µs (SLO: <10.000µs 📉 -85.2%) vs baseline: +4.6% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +3.8% ✅ repr_noaspectTime: ✅ 0.524µs (SLO: <10.000µs 📉 -94.8%) vs baseline: +0.2% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +3.6% ✅ rstrip_aspectTime: ✅ 19.128µs (SLO: <30.000µs 📉 -36.2%) vs baseline: +1.0% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ rstrip_noaspectTime: ✅ 1.917µs (SLO: <10.000µs 📉 -80.8%) vs baseline: +0.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.0% ✅ slice_aspectTime: ✅ 15.938µs (SLO: <20.000µs 📉 -20.3%) vs baseline: +0.9% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +3.8% ✅ slice_noaspectTime: ✅ 0.595µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.8% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +3.9% ✅ stringio_aspectTime: ✅ 54.373µs (SLO: <80.000µs 📉 -32.0%) vs baseline: +0.9% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +3.9% ✅ stringio_noaspectTime: ✅ 3.623µs (SLO: <10.000µs 📉 -63.8%) vs baseline: +0.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.1% ✅ strip_aspectTime: ✅ 17.744µs (SLO: <20.000µs 📉 -11.3%) vs baseline: +0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.0% ✅ strip_noaspectTime: ✅ 1.869µs (SLO: <10.000µs 📉 -81.3%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ swapcase_aspectTime: ✅ 18.473µs (SLO: <30.000µs 📉 -38.4%) vs baseline: ~same Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +3.8% ✅ swapcase_noaspectTime: ✅ 2.792µs (SLO: <10.000µs 📉 -72.1%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.8% ✅ title_aspectTime: ✅ 18.303µs (SLO: <30.000µs 📉 -39.0%) vs baseline: +0.3% Memory: ✅ 42.703MB (SLO: <43.000MB 🟡 -0.7%) vs baseline: +4.3% ✅ title_noaspectTime: ✅ 2.664µs (SLO: <10.000µs 📉 -73.4%) vs baseline: -0.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ translate_aspectTime: ✅ 20.513µs (SLO: <30.000µs 📉 -31.6%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ translate_noaspectTime: ✅ 4.329µs (SLO: <10.000µs 📉 -56.7%) vs baseline: +0.6% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +3.8% ✅ upper_aspectTime: ✅ 18.121µs (SLO: <30.000µs 📉 -39.6%) vs baseline: +1.2% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +3.6% ✅ upper_noaspectTime: ✅ 2.430µs (SLO: <10.000µs 📉 -75.7%) vs baseline: -0.6% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.195µs (SLO: <10.000µs 📉 -48.0%) vs baseline: 📈 +21.4% Memory: ✅ 41.524MB (SLO: <43.500MB -4.5%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 4.303µs (SLO: <10.000µs 📉 -57.0%) vs baseline: ~same Memory: ✅ 41.524MB (SLO: <43.500MB -4.5%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 6.242µs (SLO: <10.000µs 📉 -37.6%) vs baseline: ~same Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 6.278µs (SLO: <10.000µs 📉 -37.2%) vs baseline: -0.7% Memory: ✅ 41.602MB (SLO: <43.500MB -4.4%) vs baseline: +5.4% ✅ ospathnormcase_aspectTime: ✅ 3.572µs (SLO: <10.000µs 📉 -64.3%) vs baseline: ~same Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 3.597µs (SLO: <10.000µs 📉 -64.0%) vs baseline: -0.5% Memory: ✅ 41.583MB (SLO: <43.500MB -4.4%) vs baseline: +5.3% ✅ ospathsplit_aspectTime: ✅ 4.916µs (SLO: <10.000µs 📉 -50.8%) vs baseline: -0.3% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 5.050µs (SLO: <10.000µs 📉 -49.5%) vs baseline: +0.4% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.750µs (SLO: <10.000µs 📉 -62.5%) vs baseline: +0.3% Memory: ✅ 41.524MB (SLO: <43.500MB -4.5%) vs baseline: +5.3% ✅ ospathsplitdrive_noaspectTime: ✅ 0.752µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -0.6% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.638µs (SLO: <10.000µs 📉 -53.6%) vs baseline: +0.4% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 4.652µs (SLO: <10.000µs 📉 -53.5%) vs baseline: ~same Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.387µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +13.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 200.430µs (SLO: <220.000µs -8.9%) vs baseline: +0.9% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.316µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.2% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.648µs (SLO: <230.000µs -7.1%) vs baseline: ~same Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.157µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -1.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.497µs (SLO: <150.000µs -9.0%) vs baseline: +0.3% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.116µs (SLO: <20.000µs 📉 -84.4%) vs baseline: -0.7% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 212.746µs (SLO: <250.000µs 📉 -14.9%) vs baseline: -0.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.082ms (SLO: <22.000ms -8.7%) vs baseline: +1.1% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.238ms (SLO: <2.550ms 📉 -12.3%) vs baseline: +1.1% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.4% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.407ms (SLO: <1.550ms -9.2%) vs baseline: +1.0% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 100-rate-metrics-100-timesTime: ✅ 2.205ms (SLO: <2.550ms 📉 -13.5%) vs baseline: +2.0% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.592µs (SLO: <20.000µs 📉 -77.0%) vs baseline: -0.7% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 173.543µs (SLO: <250.000µs 📉 -30.6%) vs baseline: -0.4% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.167ms (SLO: <2.500ms 📉 -13.3%) vs baseline: -1.5% Memory: ✅ 36.078MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +5.0% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
3d721e5 to
65184bb
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
[email protected] unqueued this merge request |
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the venvs_per_job: 1. the release notes and riotfile change lgtm
|
/remove |
|
View all feedbacks in Devflow UI.
|
ae78f21 to
dae97e0
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
d9f3443 to
062708f
Compare
062708f to
695e88c
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
This pull request was merged directly. |
Description
This PR adds instrumentation of the Stripe SDKs for AppSec, by sending addresses to the WAF for the following function calls:
payment_intentTesting
This PR includes unittests for the instrumented functions using
vcrpycassettes with recorded Stripe API responses, and webhook samples generated by the stripe cli.The tests ensure compatibility with the Stripe SDK version 11 and up across all python versions.
Risks
None
Additional Notes