Fix null ref in IpcTcpProcessMessageIntegration #8023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8023) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (68ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8023) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 74
section CallTarget+Inlining+NGEN
This PR (8023) - mean (1,015ms) : 957, 1073
master - mean (1,013ms) : 948, 1078
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (106ms) : 104, 108
master - mean (105ms) : 103, 108
section Bailout
This PR (8023) - mean (107ms) : 105, 108
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (8023) - mean (738ms) : 668, 808
master - mean (735ms) : 667, 804
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (94ms) : 92, 96
master - mean (93ms) : 91, 95
section Bailout
This PR (8023) - mean (96ms) : 88, 104
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8023) - mean (713ms) : 685, 742
master - mean (708ms) : 671, 745
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (92ms) : 90, 94
master - mean (92ms) : 90, 94
section Bailout
This PR (8023) - mean (94ms) : 92, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8023) - mean (636ms) : 619, 653
master - mean (634ms) : 617, 650
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (193ms) : 190, 197
master - mean (194ms) : 190, 198
section Bailout
This PR (8023) - mean (197ms) : 195, 199
master - mean (197ms) : 193, 201
section CallTarget+Inlining+NGEN
This PR (8023) - mean (1,123ms) : 1064, 1181
master - mean (1,112ms) : 1054, 1170
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (277ms) : 273, 282
master - mean (276ms) : 272, 281
section Bailout
This PR (8023) - mean (278ms) : 273, 282
master - mean (277ms) : 274, 280
section CallTarget+Inlining+NGEN
This PR (8023) - mean (928ms) : 881, 975
master - mean (925ms) : 883, 967
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (270ms) : 266, 275
master - mean (270ms) : 266, 274
section Bailout
This PR (8023) - mean (270ms) : 267, 274
master - mean (270ms) : 267, 273
section CallTarget+Inlining+NGEN
This PR (8023) - mean (930ms) : 877, 983
master - mean (931ms) : 898, 964
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8023) - mean (277ms) : 265, 289
master - mean (269ms) : 264, 275
section Bailout
This PR (8023) - mean (274ms) : 264, 285
master - mean (270ms) : 266, 274
section CallTarget+Inlining+NGEN
This PR (8023) - mean (835ms) : 812, 859
master - mean (822ms) : 807, 837
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes a
NullReferenceExceptioninIpcTcpProcessMessageIntegration.Reason for change
Previously the code was just doing this:
tracer.InternalActiveScope is var scopeAnd then we were calling
scope.Span.Contextbut theSpanproperty can benull.Implementation details
Swapped to the property pattern
{ }which should address it.Test coverage
I didn't update any tests
Other details