Skip to content

pass lambda request ID to extension #8015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
shreyamalpani wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

pass lambda request ID to extension #8015

shreyamalpani wants to merge 1 commit into from
+7 −0

Conversation

@shreyamalpani
Copy link
Contributor

@shreyamalpani shreyamalpani commented Dec 26, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 26, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8015) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.39 ± (68.41 - 68.67) ms68.49 ± (68.54 - 68.77) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration72.19 ± (72.14 - 72.35) ms72.27 ± (72.21 - 72.44) ms+0.1%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1005.50 ± (1005.43 - 1010.86) ms1005.95 ± (1008.12 - 1015.78) ms+0.0%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.05 ± (22.02 - 22.09) ms21.95 ± (21.92 - 21.98) ms-0.5%✅
process.time_to_main_ms79.12 ± (78.95 - 79.28) ms79.21 ± (79.06 - 79.36) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.95 - 10.96) MB10.92 ± (10.92 - 10.93) MB-0.3%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.89 ± (21.85 - 21.92) ms21.89 ± (21.87 - 21.92) ms+0.0%✅⬆️
process.time_to_main_ms80.11 ± (80.02 - 80.21) ms80.31 ± (80.21 - 80.41) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.95 - 10.96) MB10.96 ± (10.96 - 10.97) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms251.57 ± (247.68 - 255.47) ms239.98 ± (235.86 - 244.11) ms-4.6%✅
process.time_to_main_ms471.47 ± (471.02 - 471.91) ms470.24 ± (469.79 - 470.69) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.22 ± (48.20 - 48.24) MB48.20 ± (48.18 - 48.22) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.6%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms20.71 ± (20.68 - 20.74) ms20.79 ± (20.76 - 20.82) ms+0.4%✅⬆️
process.time_to_main_ms68.31 ± (68.18 - 68.44) ms68.43 ± (68.30 - 68.56) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.62 ± (10.62 - 10.62) MB10.65 ± (10.65 - 10.66) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.61 ± (20.58 - 20.65) ms20.71 ± (20.69 - 20.73) ms+0.5%✅⬆️
process.time_to_main_ms69.21 ± (69.14 - 69.28) ms69.28 ± (69.22 - 69.35) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.69 ± (10.68 - 10.70) MB10.76 ± (10.75 - 10.76) MB+0.6%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms248.21 ± (247.48 - 248.95) ms244.49 ± (242.07 - 246.91) ms-1.5%✅
process.time_to_main_ms440.37 ± (439.91 - 440.83) ms442.07 ± (441.65 - 442.49) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.64 ± (48.61 - 48.67) MB48.62 ± (48.59 - 48.65) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms18.92 ± (18.90 - 18.95) ms18.80 ± (18.77 - 18.83) ms-0.7%✅
process.time_to_main_ms67.45 ± (67.34 - 67.56) ms66.93 ± (66.81 - 67.05) ms-0.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.68 - 7.70) MB7.68 ± (7.67 - 7.69) MB-0.1%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.99 ± (18.97 - 19.02) ms18.81 ± (18.78 - 18.84) ms-0.9%✅
process.time_to_main_ms68.60 ± (68.54 - 68.66) ms68.01 ± (67.94 - 68.07) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.76 ± (7.75 - 7.77) MB7.74 ± (7.73 - 7.75) MB-0.2%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms180.57 ± (179.58 - 181.56) ms179.51 ± (178.58 - 180.44) ms-0.6%✅
process.time_to_main_ms426.04 ± (425.54 - 426.55) ms424.81 ± (424.18 - 425.44) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.35 ± (36.32 - 36.38) MB36.31 ± (36.28 - 36.34) MB-0.1%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration195.15 ± (195.22 - 196.04) ms194.09 ± (194.10 - 194.88) ms-0.5%✅
.NET Framework 4.8 - Bailout
duration199.07 ± (198.55 - 199.53) ms197.72 ± (197.96 - 199.03) ms-0.7%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1135.19 ± (1135.56 - 1146.38) ms1117.00 ± (1118.25 - 1126.62) ms-1.6%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms191.96 ± (191.49 - 192.43) ms188.06 ± (187.77 - 188.36) ms-2.0%✅
process.time_to_main_ms81.82 ± (81.58 - 82.06) ms80.84 ± (80.58 - 81.10) ms-1.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.03 ± (16.01 - 16.05) MB16.08 ± (16.05 - 16.10) MB+0.3%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.2%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms192.79 ± (192.31 - 193.27) ms187.86 ± (187.46 - 188.26) ms-2.6%✅
process.time_to_main_ms84.24 ± (83.98 - 84.49) ms82.46 ± (82.29 - 82.62) ms-2.1%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.06 - 16.10) MB16.12 ± (16.09 - 16.14) MB+0.2%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)20 ± (20 - 21)-0.4%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms424.61 ± (420.95 - 428.28) ms431.29 ± (428.55 - 434.03) ms+1.6%✅⬆️
process.time_to_main_ms478.60 ± (477.77 - 479.42) ms474.08 ± (473.53 - 474.64) ms-0.9%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.59 ± (58.47 - 58.70) MB58.49 ± (58.37 - 58.61) MB-0.2%✅
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 30)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms192.24 ± (191.84 - 192.63) ms192.56 ± (192.18 - 192.95) ms+0.2%✅⬆️
process.time_to_main_ms69.90 ± (69.73 - 70.08) ms70.15 ± (70.00 - 70.30) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.91 ± (15.75 - 16.06) MB15.93 ± (15.78 - 16.08) MB+0.1%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.6%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms192.02 ± (191.67 - 192.36) ms195.19 ± (194.70 - 195.67) ms+1.7%✅⬆️
process.time_to_main_ms70.95 ± (70.84 - 71.06) ms71.94 ± (71.76 - 72.12) ms+1.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.26 ± (16.17 - 16.36) MB16.38 ± (16.32 - 16.43) MB+0.7%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.9%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms455.42 ± (453.31 - 457.54) ms453.40 ± (450.99 - 455.80) ms-0.4%✅
process.time_to_main_ms445.85 ± (445.29 - 446.42) ms446.70 ± (446.15 - 447.25) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.12 ± (58.01 - 58.23) MB58.42 ± (58.31 - 58.54) MB+0.5%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)30 ± (29 - 30)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms190.47 ± (190.15 - 190.78) ms190.58 ± (190.25 - 190.91) ms+0.1%✅⬆️
process.time_to_main_ms69.62 ± (69.41 - 69.84) ms69.60 ± (69.42 - 69.78) ms-0.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.76 ± (11.73 - 11.79) MB11.73 ± (11.70 - 11.75) MB-0.3%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.2%✅
.NET 8 - Bailout
process.internal_duration_ms189.78 ± (189.50 - 190.06) ms190.50 ± (190.04 - 190.96) ms+0.4%✅⬆️
process.time_to_main_ms70.59 ± (70.46 - 70.71) ms71.07 ± (70.89 - 71.26) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.83 ± (11.81 - 11.86) MB11.80 ± (11.77 - 11.82) MB-0.3%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms365.05 ± (363.40 - 366.71) ms366.72 ± (365.16 - 368.27) ms+0.5%✅⬆️
process.time_to_main_ms431.53 ± (430.92 - 432.13) ms431.06 ± (430.29 - 431.84) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.91 ± (47.88 - 47.94) MB47.96 ± (47.93 - 47.99) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.5%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8015) - mean (69ms)  : 67, 70
    master - mean (69ms)  : 67, 70

    section Bailout
    This PR (8015) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (8015) - mean (1,012ms)  : 957, 1067
    master - mean (1,008ms)  : 970, 1047
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8015) - mean (107ms)  : 104, 109
    master - mean (107ms)  : 103, 110

    section Bailout
    This PR (8015) - mean (107ms)  : 106, 109
    master - mean (107ms)  : 106, 108

    section CallTarget+Inlining+NGEN
    This PR (8015) - mean (737ms)  : 671, 803
    master - mean (745ms)  : 674, 815
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8015) - mean (94ms)  : 92, 96
    master - mean (94ms)  : 92, 96

    section Bailout
    This PR (8015) - mean (95ms)  : 94, 96
    master - mean (95ms)  : 93, 96

    section CallTarget+Inlining+NGEN
    This PR (8015) - mean (711ms)  : 669, 752
    master - mean (717ms)  : 694, 741
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8015) - mean (92ms)  : 90, 94
    master - mean (92ms)  : 90, 95

    section Bailout
    This PR (8015) - mean (93ms)  : 91, 94
    master - mean (94ms)  : 93, 95

    section CallTarget+Inlining+NGEN
    This PR (8015) - mean (633ms)  : 614, 651
    master - mean (635ms)  : 618, 651
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8015) - mean (194ms)  : 190, 199
    master - mean (196ms)  : 190, 201

    section Bailout
    This PR (8015) - mean (198ms)  : 193, 204
    master - mean (199ms)  : 194, 204

    section CallTarget+Inlining+NGEN
    This PR (8015) - mean (1,122ms)  : 1059, 1186
    master - mean (1,141ms)  : 1060, 1222
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8015) - mean (277ms)  : 271, 283
    master - mean (283ms)  : 271, 295

    section Bailout
    This PR (8015) - mean (279ms)  : 274, 284
    master - mean (286ms)  : 274, 298

    section CallTarget+Inlining+NGEN
    This PR (8015) - mean (935ms)  : 898, 971
    master - mean (935ms)  : 886, 985
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8015) - mean (271ms)  : 267, 275
    master - mean (270ms)  : 265, 275

    section Bailout
    This PR (8015) - mean (275ms)  : 268, 282
    master - mean (271ms)  : 267, 275

    section CallTarget+Inlining+NGEN
    This PR (8015) - mean (928ms)  : 883, 972
    master - mean (929ms)  : 893, 964
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8015) - mean (270ms)  : 265, 275
    master - mean (270ms)  : 265, 275

    section Bailout
    This PR (8015) - mean (271ms)  : 264, 279
    master - mean (270ms)  : 267, 273

    section CallTarget+Inlining+NGEN
    This PR (8015) - mean (829ms)  : 807, 851
    master - mean (826ms)  : 803, 849
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:integrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shreyamalpani