Retry DownloadLibDatadog #8014
Draft
Retry DownloadLibDatadog #8014
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:builds
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8014) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8014) - mean (72ms) : 71, 74
master - mean (72ms) : 71, 74
section CallTarget+Inlining+NGEN
This PR (8014) - mean (1,009ms) : 966, 1052
master - mean (1,006ms) : 963, 1049
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (106ms) : 104, 109
master - mean (106ms) : 103, 108
section Bailout
This PR (8014) - mean (107ms) : 106, 109
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8014) - mean (739ms) : 675, 802
master - mean (738ms) : 669, 808
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (94ms) : 92, 96
master - mean (93ms) : 91, 95
section Bailout
This PR (8014) - mean (95ms) : 94, 96
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8014) - mean (715ms) : 675, 754
master - mean (707ms) : 668, 745
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (93ms) : 90, 95
master - mean (92ms) : 90, 94
section Bailout
This PR (8014) - mean (94ms) : 92, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8014) - mean (631ms) : 618, 644
master - mean (631ms) : 618, 644
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (193ms) : 188, 199
master - mean (195ms) : 189, 200
section Bailout
This PR (8014) - mean (197ms) : 194, 200
master - mean (197ms) : 194, 200
section CallTarget+Inlining+NGEN
This PR (8014) - mean (1,114ms) : 1060, 1168
master - mean (1,115ms) : 1048, 1182
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (278ms) : 270, 287
master - mean (277ms) : 271, 283
section Bailout
This PR (8014) - mean (279ms) : 273, 285
master - mean (277ms) : 272, 283
section CallTarget+Inlining+NGEN
This PR (8014) - mean (929ms) : 889, 968
master - mean (918ms) : 858, 977
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (271ms) : 266, 275
master - mean (270ms) : 266, 275
section Bailout
This PR (8014) - mean (270ms) : 267, 274
master - mean (270ms) : 266, 274
section CallTarget+Inlining+NGEN
This PR (8014) - mean (928ms) : 893, 963
master - mean (927ms) : 897, 958
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (269ms) : 265, 274
master - mean (269ms) : 264, 275
section Bailout
This PR (8014) - mean (270ms) : 265, 274
master - mean (269ms) : 265, 274
section CallTarget+Inlining+NGEN
This PR (8014) - mean (827ms) : 803, 850
master - mean (823ms) : 802, 844
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2025-12-26 13:02:35 Comparing candidate commit 6fdee61 in PR branch Found 5 performance improvements and 7 performance regressions! Performance is the same for 155 metrics, 19 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add retry logic with exponential backoff to the
DownloadLibDatadogbuild step for Windows to handle transient network failures when vcpkg downloads dependencies from GitHub.Reason for change
CI builds occasionally fail with 504 Gateway Timeout errors when vcpkg attempts to download tools like
7zr.exefrom GitHub during theDownloadLibDatadogstep. These transient failures cause unnecessary build failures.Example error from CI:
error: https://github.com/ip7z/7zip/releases/download/25.01/7zr.exe: failed: status code 504
Implementation details
DownloadWafVersionretry implementationTest coverage
Existing CI tests will validate the change. The retry mechanism only activates on failures, so successful builds are unaffected.
Other details