Automatic retry ASM integration tests under failure #8011
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:builds
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8011) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8011) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8011) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 74
section CallTarget+Inlining+NGEN
This PR (8011) - mean (1,010ms) : 969, 1051
master - mean (1,006ms) : 963, 1049
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8011) - mean (106ms) : 104, 109
master - mean (106ms) : 103, 108
section Bailout
This PR (8011) - mean (107ms) : 106, 109
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8011) - mean (740ms) : 672, 807
master - mean (738ms) : 669, 808
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8011) - mean (94ms) : 92, 96
master - mean (93ms) : 91, 95
section Bailout
This PR (8011) - mean (95ms) : 94, 96
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8011) - mean (714ms) : 686, 743
master - mean (707ms) : 668, 745
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8011) - mean (92ms) : 90, 95
master - mean (92ms) : 90, 94
section Bailout
This PR (8011) - mean (94ms) : 93, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8011) - mean (632ms) : 618, 645
master - mean (631ms) : 618, 644
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8011) - mean (193ms) : 189, 197
master - mean (195ms) : 189, 200
section Bailout
This PR (8011) - mean (197ms) : 195, 199
master - mean (197ms) : 194, 200
section CallTarget+Inlining+NGEN
This PR (8011) - mean (1,120ms) : 1052, 1188
master - mean (1,115ms) : 1048, 1182
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8011) - mean (277ms) : 273, 282
master - mean (277ms) : 271, 283
section Bailout
This PR (8011) - mean (278ms) : 274, 281
master - mean (277ms) : 272, 283
section CallTarget+Inlining+NGEN
This PR (8011) - mean (926ms) : 873, 979
master - mean (918ms) : 858, 977
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8011) - mean (271ms) : 265, 277
master - mean (270ms) : 266, 275
section Bailout
This PR (8011) - mean (270ms) : 268, 273
master - mean (270ms) : 266, 274
section CallTarget+Inlining+NGEN
This PR (8011) - mean (931ms) : 896, 967
master - mean (927ms) : 897, 958
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8011) - mean (270ms) : 264, 277
master - mean (269ms) : 264, 275
section Bailout
This PR (8011) - mean (270ms) : 264, 277
master - mean (269ms) : 265, 274
section CallTarget+Inlining+NGEN
This PR (8011) - mean (823ms) : 805, 841
master - mean (823ms) : 802, 844
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2025-12-26 12:28:31 Comparing candidate commit 48127d7 in PR branch Found 7 performance improvements and 10 performance regressions! Performance is the same for 152 metrics, 17 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The following jobs have been found flaky, mostly due to a already reported crash condition:
The complete flakiness report can be found here:
https://docs.google.com/spreadsheets/d/1Gftmhb-66Dag4qFEXw9tyXp7U0fOQsdCE2gI-1voWyA/edit?gid=1708590243#gid=1708590243
The affected jobs will automatically be retried once to avoid CI flakiness.
For other teams, the flaky tests have been marked as flaky, which causes automatic retry. In the case of ASM, the failure does not occur on especific tests, so marking some of them would not solve the issue. This change can be reverted once the jobs are more stable.
This PR is part of an initiative of marking the most flaky tests or jobs of all the teams.
Reason for change
Implementation details
Test coverage
Other details