Skip to content

Conversation

@anna-git
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@anna-git anna-git changed the title Add step for release [Config Registry] 8/8 Add step for release Dec 23, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 23, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 40 Tests failed

FiresCallbackOnRecheckIfHasChangesToConfig from Datadog.Trace.Tests.Agent.DiscoveryServiceTests (Datadog) (Fix with Cursor)
Expected mutex3.Wait(30_000) to be True because Should make third request to api, but found False.
AllConfigurationValuesAreRegisteredWithIntake from Datadog.Trace.Tests.Telemetry.ConfigurationTests (Datadog) (Fix with Cursor)
Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_AwsEventBridge_ENABLED"}.
AllConfigurationValuesAreRegisteredWithIntake from Datadog.Trace.Tests.Telemetry.ConfigurationTests (Datadog) (Fix with Cursor)
Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_AwsEventBridge_ENABLED"}.
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5238bc0 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8009) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.24 ± (68.23 - 68.42) ms68.36 ± (68.39 - 68.65) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration71.98 ± (71.93 - 72.16) ms72.20 ± (72.05 - 72.26) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1004.14 ± (1010.66 - 1020.72) ms1008.19 ± (1009.94 - 1017.19) ms+0.4%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.02 ± (21.98 - 22.06) ms22.06 ± (22.04 - 22.09) ms+0.2%✅⬆️
process.time_to_main_ms78.78 ± (78.61 - 78.95) ms78.65 ± (78.50 - 78.80) ms-0.2%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.95 ± (10.94 - 10.95) MB+0.4%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms21.93 ± (21.91 - 21.96) ms21.87 ± (21.85 - 21.90) ms-0.3%
process.time_to_main_ms79.86 ± (79.78 - 79.95) ms79.72 ± (79.62 - 79.82) ms-0.2%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.94 ± (10.94 - 10.95) MB10.95 ± (10.95 - 10.96) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms210.36 ± (208.88 - 211.85) ms210.05 ± (208.70 - 211.41) ms-0.1%
process.time_to_main_ms471.25 ± (470.64 - 471.87) ms473.00 ± (472.34 - 473.65) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.09 ± (48.07 - 48.12) MB48.05 ± (48.03 - 48.07) MB-0.1%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%
.NET 6 - Baseline
process.internal_duration_ms20.79 ± (20.77 - 20.82) ms20.64 ± (20.61 - 20.66) ms-0.8%
process.time_to_main_ms68.40 ± (68.26 - 68.54) ms68.14 ± (68.02 - 68.26) ms-0.4%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.59 ± (10.58 - 10.59) MB10.63 ± (10.62 - 10.63) MB+0.4%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms20.72 ± (20.70 - 20.75) ms20.50 ± (20.47 - 20.53) ms-1.1%
process.time_to_main_ms69.16 ± (69.10 - 69.23) ms68.73 ± (68.68 - 68.78) ms-0.6%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.71 ± (10.71 - 10.72) MB10.66 ± (10.65 - 10.66) MB-0.5%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms200.41 ± (199.51 - 201.32) ms199.10 ± (198.00 - 200.20) ms-0.7%
process.time_to_main_ms440.66 ± (439.87 - 441.44) ms439.62 ± (439.16 - 440.08) ms-0.2%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.45 ± (48.40 - 48.50) MB48.28 ± (48.21 - 48.36) MB-0.3%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%
.NET 8 - Baseline
process.internal_duration_ms18.82 ± (18.79 - 18.85) ms18.86 ± (18.83 - 18.88) ms+0.2%✅⬆️
process.time_to_main_ms67.21 ± (67.10 - 67.31) ms66.97 ± (66.88 - 67.06) ms-0.4%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.65 ± (7.65 - 7.66) MB7.68 ± (7.67 - 7.69) MB+0.4%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms18.70 ± (18.68 - 18.73) ms18.86 ± (18.84 - 18.89) ms+0.9%✅⬆️
process.time_to_main_ms68.06 ± (68.01 - 68.11) ms68.06 ± (68.01 - 68.11) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.73) MB7.72 ± (7.71 - 7.73) MB+0.0%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms179.05 ± (178.19 - 179.90) ms179.66 ± (178.77 - 180.55) ms+0.3%✅⬆️
process.time_to_main_ms422.60 ± (422.13 - 423.07) ms426.09 ± (425.56 - 426.63) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.31 ± (36.28 - 36.34) MB36.34 ± (36.31 - 36.37) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.0%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.39 ± (193.35 - 194.00) ms195.02 ± (195.06 - 196.10) ms+0.8%✅⬆️
.NET Framework 4.8 - Bailout
duration196.97 ± (196.95 - 197.77) ms199.44 ± (199.16 - 200.08) ms+1.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1111.82 ± (1115.44 - 1124.23) ms1121.64 ± (1122.82 - 1131.04) ms+0.9%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms189.44 ± (189.00 - 189.88) ms194.55 ± (194.03 - 195.06) ms+2.7%✅⬆️
process.time_to_main_ms80.86 ± (80.65 - 81.08) ms83.24 ± (82.96 - 83.51) ms+2.9%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.08 ± (16.06 - 16.11) MB16.02 ± (16.00 - 16.04) MB-0.4%
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.2%
.NET Core 3.1 - Bailout
process.internal_duration_ms187.26 ± (187.02 - 187.50) ms195.78 ± (195.32 - 196.25) ms+4.6%✅⬆️
process.time_to_main_ms82.11 ± (81.95 - 82.27) ms85.85 ± (85.61 - 86.09) ms+4.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.17 ± (16.14 - 16.19) MB16.02 ± (16.00 - 16.04) MB-0.9%
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (20 - 21)-0.3%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms398.17 ± (395.26 - 401.08) ms407.43 ± (405.15 - 409.72) ms+2.3%✅⬆️
process.time_to_main_ms474.49 ± (473.87 - 475.11) ms496.81 ± (495.69 - 497.93) ms+4.7%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed58.08 ± (57.93 - 58.24) MB59.04 ± (58.97 - 59.11) MB+1.6%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)30 ± (29 - 30)+0.3%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms192.09 ± (191.70 - 192.47) ms196.53 ± (196.04 - 197.02) ms+2.3%✅⬆️
process.time_to_main_ms69.83 ± (69.64 - 70.01) ms71.11 ± (70.90 - 71.33) ms+1.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.20 ± (16.08 - 16.32) MB16.36 ± (16.35 - 16.38) MB+1.0%✅⬆️
runtime.dotnet.threads.count19 ± (18 - 19)19 ± (19 - 19)+3.2%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms191.49 ± (191.16 - 191.82) ms193.60 ± (193.20 - 194.00) ms+1.1%✅⬆️
process.time_to_main_ms70.81 ± (70.70 - 70.92) ms71.41 ± (71.26 - 71.56) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.27 ± (16.16 - 16.39) MB16.38 ± (16.30 - 16.46) MB+0.7%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (20 - 20)+2.6%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms411.39 ± (408.89 - 413.89) ms411.91 ± (409.20 - 414.61) ms+0.1%✅⬆️
process.time_to_main_ms445.57 ± (444.98 - 446.16) ms448.25 ± (447.66 - 448.85) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed59.30 ± (59.19 - 59.42) MB58.86 ± (58.72 - 59.01) MB-0.7%
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (29 - 30)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms190.85 ± (190.48 - 191.21) ms192.02 ± (191.64 - 192.39) ms+0.6%✅⬆️
process.time_to_main_ms69.52 ± (69.35 - 69.70) ms70.05 ± (69.82 - 70.28) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.73 ± (11.70 - 11.76) MB11.74 ± (11.71 - 11.77) MB+0.1%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.2%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms189.72 ± (189.46 - 189.97) ms193.39 ± (192.91 - 193.88) ms+1.9%✅⬆️
process.time_to_main_ms70.35 ± (70.26 - 70.44) ms71.53 ± (71.38 - 71.69) ms+1.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.86 ± (11.83 - 11.89) MB11.78 ± (11.75 - 11.80) MB-0.7%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.3%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms365.97 ± (364.58 - 367.35) ms366.49 ± (365.15 - 367.83) ms+0.1%✅⬆️
process.time_to_main_ms427.54 ± (426.84 - 428.25) ms429.35 ± (428.72 - 429.98) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed47.98 ± (47.95 - 48.01) MB47.96 ± (47.92 - 48.00) MB-0.0%
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8009) - mean (69ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (8009) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (8009) - mean (1,014ms)  : 962, 1065
    master - mean (1,016ms)  : 942, 1090

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8009) - mean (106ms)  : 103, 109
    master - mean (106ms)  : 104, 108

    section Bailout
    This PR (8009) - mean (107ms)  : 106, 108
    master - mean (107ms)  : 106, 108

    section CallTarget+Inlining+NGEN
    This PR (8009) - mean (710ms)  : 683, 737
    master - mean (710ms)  : 683, 736

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8009) - mean (94ms)  : 92, 96
    master - mean (94ms)  : 92, 96

    section Bailout
    This PR (8009) - mean (94ms)  : 93, 95
    master - mean (95ms)  : 93, 96

    section CallTarget+Inlining+NGEN
    This PR (8009) - mean (667ms)  : 645, 689
    master - mean (668ms)  : 635, 701

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8009) - mean (92ms)  : 90, 94
    master - mean (92ms)  : 90, 94

    section Bailout
    This PR (8009) - mean (93ms)  : 92, 94
    master - mean (93ms)  : 91, 94

    section CallTarget+Inlining+NGEN
    This PR (8009) - mean (633ms)  : 618, 647
    master - mean (629ms)  : 614, 644

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8009) - mean (196ms)  : 189, 202
    master - mean (194ms)  : 190, 197

    section Bailout
    This PR (8009) - mean (200ms)  : 195, 204
    master - mean (197ms)  : 193, 201

    section CallTarget+Inlining+NGEN
    This PR (8009) - mean (1,127ms)  : 1069, 1185
    master - mean (1,120ms)  : 1054, 1186

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8009) - mean (286ms)  : 273, 299
    master - mean (279ms)  : 270, 288

    section Bailout
    This PR (8009) - mean (290ms)  : 283, 297
    master - mean (277ms)  : 274, 281

    section CallTarget+Inlining+NGEN
    This PR (8009) - mean (946ms)  : 898, 993
    master - mean (905ms)  : 854, 955

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8009) - mean (276ms)  : 266, 287
    master - mean (271ms)  : 266, 275

    section Bailout
    This PR (8009) - mean (273ms)  : 269, 278
    master - mean (270ms)  : 266, 274

    section CallTarget+Inlining+NGEN
    This PR (8009) - mean (893ms)  : 849, 938
    master - mean (891ms)  : 840, 942

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8009) - mean (272ms)  : 266, 277
    master - mean (270ms)  : 265, 274

    section Bailout
    This PR (8009) - mean (275ms)  : 269, 281
    master - mean (270ms)  : 266, 273

    section CallTarget+Inlining+NGEN
    This PR (8009) - mean (826ms)  : 809, 843
    master - mean (824ms)  : 802, 846

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants