Skip some errors from being sent to telemetry #8003
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
approved these changes
Dec 23, 2025
| if (jsonFiles.Length == 0) | ||
| { | ||
| Log.Error("'{InputFolder}' doesn't contain any json file.", inputFolder); | ||
| Log.ErrorSkipTelemetry("'{InputFolder}' doesn't contain any json file.", inputFolder); |
Member
There was a problem hiding this comment.
@tonyredondo is this actually an error, or should it just be a warning? (ErrorSkipTelemetry is obvs fine for now, unless we hear otherwise)
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8003) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8003) - mean (69ms) : 67, 71
master - mean (68ms) : 67, 70
section Bailout
This PR (8003) - mean (72ms) : 71, 74
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8003) - mean (1,013ms) : 954, 1071
master - mean (1,007ms) : 964, 1050
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8003) - mean (106ms) : 103, 109
master - mean (105ms) : 103, 108
section Bailout
This PR (8003) - mean (107ms) : 106, 108
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8003) - mean (708ms) : 681, 734
master - mean (712ms) : 677, 747
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8003) - mean (94ms) : 91, 96
master - mean (93ms) : 92, 95
section Bailout
This PR (8003) - mean (94ms) : 93, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8003) - mean (669ms) : 649, 689
master - mean (671ms) : 624, 719
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8003) - mean (92ms) : 89, 95
master - mean (92ms) : 89, 95
section Bailout
This PR (8003) - mean (93ms) : 92, 94
master - mean (93ms) : 91, 94
section CallTarget+Inlining+NGEN
This PR (8003) - mean (631ms) : 616, 646
master - mean (631ms) : 617, 644
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8003) - mean (195ms) : 191, 198
master - mean (193ms) : 189, 198
section Bailout
This PR (8003) - mean (197ms) : 194, 200
master - mean (196ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (8003) - mean (1,118ms) : 1053, 1183
master - mean (1,111ms) : 1061, 1162
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8003) - mean (291ms) : 273, 309
master - mean (277ms) : 272, 281
section Bailout
This PR (8003) - mean (301ms) : crit, 296, 306
master - mean (277ms) : 274, 281
section CallTarget+Inlining+NGEN
This PR (8003) - mean (930ms) : 875, 984
master - mean (907ms) : 867, 948
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8003) - mean (275ms) : 269, 281
master - mean (269ms) : 265, 274
section Bailout
This PR (8003) - mean (274ms) : 266, 281
master - mean (270ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (8003) - mean (893ms) : 848, 938
master - mean (888ms) : 850, 926
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8003) - mean (272ms) : 262, 281
master - mean (269ms) : 264, 274
section Bailout
This PR (8003) - mean (269ms) : 265, 273
master - mean (269ms) : 265, 273
section CallTarget+Inlining+NGEN
This PR (8003) - mean (825ms) : 804, 845
master - mean (826ms) : 802, 849
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Skips a few errors that are
Ignoredin Error Tracking and shouldn't really be sent to telemetry as we can't act on them.Reason for change
Nothing we can really do about these.
Implementation details
Marked as
ErrorSkipTelemetryTest coverage
N/A
Other details
I guess one thing we do lose here is whether we want to see how often these happen?