Retry on profiler failed integration jobs #8002
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:builds
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8002) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8002) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8002) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8002) - mean (1,010ms) : 956, 1064
master - mean (1,007ms) : 964, 1050
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8002) - mean (106ms) : 103, 109
master - mean (105ms) : 103, 108
section Bailout
This PR (8002) - mean (107ms) : 105, 109
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8002) - mean (713ms) : 675, 751
master - mean (712ms) : 677, 747
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8002) - mean (94ms) : 91, 96
master - mean (93ms) : 92, 95
section Bailout
This PR (8002) - mean (94ms) : 93, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8002) - mean (665ms) : 644, 685
master - mean (671ms) : 624, 719
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8002) - mean (92ms) : 90, 94
master - mean (92ms) : 89, 95
section Bailout
This PR (8002) - mean (93ms) : 91, 94
master - mean (93ms) : 91, 94
section CallTarget+Inlining+NGEN
This PR (8002) - mean (629ms) : 614, 644
master - mean (631ms) : 617, 644
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8002) - mean (193ms) : 188, 199
master - mean (193ms) : 189, 198
section Bailout
This PR (8002) - mean (197ms) : 195, 199
master - mean (196ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (8002) - mean (1,112ms) : 1066, 1157
master - mean (1,111ms) : 1061, 1162
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8002) - mean (278ms) : 271, 285
master - mean (277ms) : 272, 281
section Bailout
This PR (8002) - mean (278ms) : 274, 282
master - mean (277ms) : 274, 281
section CallTarget+Inlining+NGEN
This PR (8002) - mean (906ms) : 861, 951
master - mean (907ms) : 867, 948
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8002) - mean (270ms) : 266, 274
master - mean (269ms) : 265, 274
section Bailout
This PR (8002) - mean (270ms) : 266, 273
master - mean (270ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (8002) - mean (886ms) : 846, 926
master - mean (888ms) : 850, 926
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8002) - mean (270ms) : 264, 275
master - mean (269ms) : 264, 274
section Bailout
This PR (8002) - mean (269ms) : 265, 272
master - mean (269ms) : 265, 273
section CallTarget+Inlining+NGEN
This PR (8002) - mean (823ms) : 799, 847
master - mean (826ms) : 802, 849
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
NachoEchevarria
changed the title
NachoEchevarria
changed the title
andrewlock
reviewed
Dec 23, 2025
|
|
||
| - script: tracer\build.cmd BuildProfilerSamples BuildAndRunProfilerIntegrationTests --TargetPlatform $(targetPlatform) | ||
| displayName: Run Profiler Integration tests | ||
| retryCountOnTaskFailure: 2 |
Member
There was a problem hiding this comment.
I don't think this will work in isolation 🤔 These currently take a long time to run, and doubling the length with likely just cause timeouts...
I think we should probably
- Split out the "build" commands here from the "run" commands
- Add a bunch of retries to those tasks
- Split by target framework as well as target platform (primarily for perf)
- See if we can add features to their custom runner to add the retries
- If we can't, retry the whole target-framework task: these should be short enough that we can retry the whole lot without hitting timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The following jobs we detected as flaky (pipeline failures / last month):
The complete flakiness report can be found here:
https://docs.google.com/spreadsheets/d/1Gftmhb-66Dag4qFEXw9tyXp7U0fOQsdCE2gI-1voWyA/edit?gid=1708590243#gid=1708590243
The affected jobs will be retried on error. This PR can be reverted after handling flaky errors.
Reason for change
Implementation details
Test coverage
Other details