[EL] DEBUG-4878 Fix null equality in expression language #7991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:tracer
|
✨ Fix all issues with Cursor
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7991) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7991) - mean (69ms) : 67, 70
master - mean (69ms) : 67, 70
section Bailout
This PR (7991) - mean (73ms) : 71, 74
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (7991) - mean (1,012ms) : 965, 1060
master - mean (1,008ms) : 959, 1058
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7991) - mean (106ms) : 104, 109
master - mean (106ms) : 103, 108
section Bailout
This PR (7991) - mean (107ms) : 106, 108
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (7991) - mean (710ms) : 682, 737
master - mean (709ms) : 681, 738
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7991) - mean (94ms) : 91, 96
master - mean (94ms) : 92, 95
section Bailout
This PR (7991) - mean (95ms) : 94, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (7991) - mean (668ms) : 648, 687
master - mean (663ms) : 644, 683
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7991) - mean (92ms) : 90, 95
master - mean (92ms) : 90, 94
section Bailout
This PR (7991) - mean (93ms) : 92, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (7991) - mean (628ms) : 614, 643
master - mean (634ms) : 619, 648
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7991) - mean (194ms) : 190, 199
master - mean (193ms) : 189, 197
section Bailout
This PR (7991) - mean (197ms) : 194, 201
master - mean (196ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (7991) - mean (1,117ms) : 1054, 1180
master - mean (1,119ms) : 1052, 1186
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7991) - mean (277ms) : 272, 283
master - mean (276ms) : 270, 282
section Bailout
This PR (7991) - mean (279ms) : 273, 284
master - mean (276ms) : 273, 280
section CallTarget+Inlining+NGEN
This PR (7991) - mean (914ms) : 867, 960
master - mean (904ms) : 856, 952
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7991) - mean (270ms) : 265, 274
master - mean (270ms) : 265, 275
section Bailout
This PR (7991) - mean (271ms) : 264, 277
master - mean (269ms) : 266, 272
section CallTarget+Inlining+NGEN
This PR (7991) - mean (889ms) : 844, 934
master - mean (885ms) : 847, 923
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7991) - mean (268ms) : 264, 272
master - mean (268ms) : 264, 273
section Bailout
This PR (7991) - mean (269ms) : 265, 274
master - mean (269ms) : 266, 272
section CallTarget+Inlining+NGEN
This PR (7991) - mean (823ms) : 797, 848
master - mean (820ms) : 801, 839
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Harden binary equality handling (
==/!=) in the probe expression parser to avoid runtime exceptions and produce predictable results when comparing:nullnullwhen the runtime type differs from the compile-time typeImplementation details
==and!=through a dedicatedEqualExpression()helper.non-nullable value typevsnull:falsefor==,truefor!=) since the comparison outcome is deterministic.reference typevsnull:Expression.ReferenceEqualonobject-converted operands to ensure object-reference semantics and avoid type-cast issues.Test coverage
Snapshot Exploration Test
Other details
This PR is part of an effort to make the Snapshot Exploration Test run successfully end-to-end.