[Dynamic Instrumentation] DEBUG-4786 Explicitly track open nodes #7988
+203
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:tracer
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
595
to
+599
| internal void CaptureEntryAsyncMethod<T>(ref CaptureInfo<T> info) | ||
| { | ||
| CaptureEntryMethodStartMarker(ref info); | ||
| bool hasArgument = CaptureAsyncMethodArguments(info.AsyncCaptureInfo.HoistedArguments, info.AsyncCaptureInfo.MoveNextInvocationTarget); | ||
| CaptureEntryMethodEndMarker(info.Value, info.Type, hasArgument); | ||
| CaptureEntryMethodEndMarker(info.Value, info.Type); |
There was a problem hiding this comment.
The new CaptureEntryAsyncMethod still declares bool hasArgument = ... but the variable is never used now that CaptureEntryMethodEndMarker no longer takes the flag. With TreatWarningsAsErrors enabled in tracer/Directory.Build.props (line 4), this unused local triggers CS0219 and fails the tracer build even though the code path is otherwise unchanged.
Useful? React with 👍 / 👎.
dudikeleti
changed the title
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7988) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7988) - mean (69ms) : 67, 70
master - mean (69ms) : 67, 70
section Bailout
This PR (7988) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (7988) - mean (1,015ms) : 954, 1076
master - mean (1,008ms) : 959, 1058
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7988) - mean (106ms) : 103, 108
master - mean (106ms) : 103, 108
section Bailout
This PR (7988) - mean (107ms) : 106, 108
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (7988) - mean (708ms) : 679, 737
master - mean (709ms) : 681, 738
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7988) - mean (93ms) : 91, 95
master - mean (94ms) : 92, 95
section Bailout
This PR (7988) - mean (94ms) : 93, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (7988) - mean (668ms) : 651, 686
master - mean (663ms) : 644, 683
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7988) - mean (92ms) : 90, 94
master - mean (92ms) : 90, 94
section Bailout
This PR (7988) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (7988) - mean (632ms) : 619, 644
master - mean (634ms) : 619, 648
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7988) - mean (195ms) : 190, 200
master - mean (193ms) : 189, 197
section Bailout
This PR (7988) - mean (197ms) : 193, 201
master - mean (196ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (7988) - mean (1,120ms) : 1051, 1189
master - mean (1,119ms) : 1052, 1186
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7988) - mean (276ms) : 271, 282
master - mean (276ms) : 270, 282
section Bailout
This PR (7988) - mean (277ms) : 272, 282
master - mean (276ms) : 273, 280
section CallTarget+Inlining+NGEN
This PR (7988) - mean (906ms) : 861, 952
master - mean (904ms) : 856, 952
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7988) - mean (270ms) : 265, 275
master - mean (270ms) : 265, 275
section Bailout
This PR (7988) - mean (270ms) : 267, 273
master - mean (269ms) : 266, 272
section CallTarget+Inlining+NGEN
This PR (7988) - mean (888ms) : 842, 934
master - mean (885ms) : 847, 923
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7988) - mean (269ms) : 263, 276
master - mean (268ms) : 264, 273
section Bailout
This PR (7988) - mean (269ms) : 265, 273
master - mean (269ms) : 266, 272
section CallTarget+Inlining+NGEN
This PR (7988) - mean (822ms) : 804, 841
master - mean (820ms) : 801, 839
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2025-12-20 13:27:54 Comparing candidate commit ad6cf9c in PR branch Found 7 performance improvements and 7 performance regressions! Performance is the same for 153 metrics, 19 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
In some cases, we cannot rely on the method metadata to determine whether method arguments and locals exist, as they may still be skipped.
Implementation details
Track open nodes and open/close them as required.
Test coverage
#7987
Other details
This PR is part of an effort to make the Snapshot Exploration Test run successfully end-to-end.
#7986
#7989