Skip to content

Conversation

@chrisnas
Copy link
Contributor

Summary of changes

  • Target .NET 10
  • Disable profilers by default

Reason for change

Ensure that new profilers that are enabled by default are disabled for targetted benchmarks
Get new numbers for .NET 10 LTS version

Implementation details

Test coverage

Manual validation

Other details

Disable profilers by default
@chrisnas chrisnas requested a review from a team as a code owner December 18, 2025 09:06
@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Dec 18, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 18, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 37 Tests failed

Baseline_allocation from Allocations.windows.json.scenarios (Datadog) (Fix with Cursor)

<null>rd Output: tnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=10.0.0&arch=x86&rid=win10-x86
Baseline_allocation from Allocations.windows.json.scenarios (Datadog) (Fix with Cursor)

<null>rd Output: tnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=10.0.0&arch=x64&rid=win10-x64
Profiler_allocation from Allocations.windows.json.scenarios (Datadog) (Fix with Cursor)

<null>rd Output: tnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=10.0.0&arch=x86&rid=win10-x86
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b159a65 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7970) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.36 ± (73.42 - 73.73) ms68.32 ± (68.36 - 68.56) ms-6.9%
.NET Framework 4.8 - Bailout
duration77.44 ± (77.33 - 77.67) ms72.02 ± (71.93 - 72.11) ms-7.0%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1043.73 ± (1051.54 - 1062.40) ms1004.27 ± (1010.96 - 1020.59) ms-3.8%
.NET Core 3.1 - Baseline
process.internal_duration_ms22.52 ± (22.47 - 22.57) ms21.81 ± (21.78 - 21.85) ms-3.1%
process.time_to_main_ms83.69 ± (83.49 - 83.89) ms78.62 ± (78.43 - 78.80) ms-6.1%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.89 ± (10.89 - 10.89) MB10.91 ± (10.90 - 10.91) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.48 ± (22.44 - 22.52) ms21.74 ± (21.72 - 21.77) ms-3.3%
process.time_to_main_ms85.60 ± (85.40 - 85.80) ms79.82 ± (79.70 - 79.95) ms-6.8%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.94 ± (10.93 - 10.94) MB10.95 ± (10.95 - 10.96) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms219.85 ± (218.54 - 221.16) ms210.77 ± (209.42 - 212.13) ms-4.1%
process.time_to_main_ms492.73 ± (491.98 - 493.49) ms473.88 ± (473.32 - 474.45) ms-3.8%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed47.99 ± (47.96 - 48.01) MB48.20 ± (48.17 - 48.22) MB+0.4%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%
.NET 6 - Baseline
process.internal_duration_ms21.39 ± (21.36 - 21.43) ms20.50 ± (20.47 - 20.53) ms-4.2%
process.time_to_main_ms73.31 ± (73.14 - 73.49) ms67.82 ± (67.69 - 67.95) ms-7.5%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.61 ± (10.60 - 10.61) MB10.64 ± (10.64 - 10.65) MB+0.4%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms21.31 ± (21.28 - 21.35) ms20.58 ± (20.55 - 20.61) ms-3.4%
process.time_to_main_ms74.28 ± (74.11 - 74.45) ms68.93 ± (68.81 - 69.06) ms-7.2%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.66 ± (10.65 - 10.66) MB10.68 ± (10.67 - 10.68) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms206.90 ± (205.89 - 207.91) ms199.24 ± (197.83 - 200.66) ms-3.7%
process.time_to_main_ms457.80 ± (457.07 - 458.53) ms439.83 ± (439.24 - 440.42) ms-3.9%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.45 ± (48.42 - 48.48) MB48.23 ± (48.15 - 48.31) MB-0.5%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.60 ± (19.57 - 19.63) ms18.84 ± (18.81 - 18.87) ms-3.8%
process.time_to_main_ms72.40 ± (72.27 - 72.54) ms66.88 ± (66.78 - 66.98) ms-7.6%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.67 ± (7.67 - 7.68) MB7.66 ± (7.65 - 7.67) MB-0.2%
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.57 ± (19.52 - 19.62) ms18.82 ± (18.79 - 18.85) ms-3.8%
process.time_to_main_ms73.84 ± (73.67 - 74.00) ms68.34 ± (68.27 - 68.41) ms-7.4%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.73 ± (7.72 - 7.74) MB7.73 ± (7.72 - 7.74) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms187.34 ± (186.55 - 188.13) ms178.41 ± (177.56 - 179.27) ms-4.8%
process.time_to_main_ms441.84 ± (441.19 - 442.49) ms424.91 ± (424.32 - 425.50) ms-3.8%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.35 ± (36.32 - 36.39) MB36.30 ± (36.27 - 36.33) MB-0.1%
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.1%

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.21 ± (193.02 - 193.76) ms193.12 ± (193.03 - 193.75) ms-0.0%
.NET Framework 4.8 - Bailout
duration197.35 ± (197.23 - 197.83) ms196.37 ± (196.10 - 196.60) ms-0.5%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1110.24 ± (1112.17 - 1120.23) ms1110.35 ± (1113.70 - 1121.73) ms+0.0%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.72 ± (187.36 - 188.08) ms187.64 ± (187.31 - 187.97) ms-0.0%
process.time_to_main_ms80.57 ± (80.34 - 80.80) ms81.06 ± (80.84 - 81.28) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.11 ± (16.08 - 16.14) MB16.12 ± (16.08 - 16.15) MB+0.0%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)-0.2%
.NET Core 3.1 - Bailout
process.internal_duration_ms187.02 ± (186.72 - 187.31) ms187.08 ± (186.79 - 187.37) ms+0.0%✅⬆️
process.time_to_main_ms81.74 ± (81.59 - 81.89) ms82.14 ± (82.00 - 82.27) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.13 ± (16.11 - 16.16) MB16.22 ± (16.19 - 16.25) MB+0.5%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+1.1%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms395.67 ± (393.09 - 398.24) ms396.08 ± (393.51 - 398.66) ms+0.1%✅⬆️
process.time_to_main_ms476.54 ± (475.78 - 477.31) ms475.47 ± (474.85 - 476.09) ms-0.2%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed58.35 ± (58.19 - 58.50) MB58.53 ± (58.38 - 58.67) MB+0.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 30)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms192.47 ± (192.09 - 192.84) ms191.64 ± (191.31 - 191.96) ms-0.4%
process.time_to_main_ms70.07 ± (69.86 - 70.28) ms70.29 ± (70.09 - 70.49) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed15.93 ± (15.77 - 16.09) MB16.20 ± (16.07 - 16.33) MB+1.7%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 19)+0.5%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms190.99 ± (190.65 - 191.33) ms191.35 ± (191.05 - 191.65) ms+0.2%✅⬆️
process.time_to_main_ms70.61 ± (70.52 - 70.70) ms71.27 ± (71.14 - 71.40) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed15.98 ± (15.82 - 16.13) MB16.28 ± (16.16 - 16.40) MB+1.9%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)20 ± (20 - 20)+3.3%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms408.83 ± (406.32 - 411.34) ms412.24 ± (409.62 - 414.85) ms+0.8%✅⬆️
process.time_to_main_ms444.75 ± (444.16 - 445.34) ms447.89 ± (447.12 - 448.65) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed58.79 ± (58.64 - 58.94) MB58.86 ± (58.71 - 59.00) MB+0.1%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (29 - 30)-0.0%
.NET 8 - Baseline
process.internal_duration_ms190.47 ± (190.08 - 190.86) ms190.87 ± (190.46 - 191.28) ms+0.2%✅⬆️
process.time_to_main_ms69.30 ± (69.12 - 69.48) ms69.96 ± (69.75 - 70.17) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.73 ± (11.70 - 11.75) MB11.72 ± (11.69 - 11.74) MB-0.1%
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.2%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms188.79 ± (188.50 - 189.09) ms189.39 ± (189.11 - 189.66) ms+0.3%✅⬆️
process.time_to_main_ms70.23 ± (70.11 - 70.35) ms70.65 ± (70.55 - 70.75) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.78 ± (11.75 - 11.81) MB11.79 ± (11.75 - 11.83) MB+0.1%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.3%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms360.05 ± (358.30 - 361.80) ms363.81 ± (362.29 - 365.32) ms+1.0%✅⬆️
process.time_to_main_ms426.78 ± (426.05 - 427.51) ms428.15 ± (427.51 - 428.78) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed47.90 ± (47.87 - 47.93) MB47.99 ± (47.96 - 48.02) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7970) - mean (68ms)  : 67, 70
    master - mean (74ms)  : 71, 76

    section Bailout
    This PR (7970) - mean (72ms)  : 71, 73
    master - mean (77ms)  : 76, 79

    section CallTarget+Inlining+NGEN
    This PR (7970) - mean (1,016ms)  : 943, 1088
    master - mean (1,057ms)  : 976, 1138

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7970) - mean (106ms)  : 103, 109
    master - mean (113ms)  : 110, 116

    section Bailout
    This PR (7970) - mean (107ms)  : 105, 108
    master - mean (115ms)  : 112, 118

    section CallTarget+Inlining+NGEN
    This PR (7970) - mean (711ms)  : 682, 740
    master - mean (745ms)  : 710, 780

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7970) - mean (93ms)  : 91, 95
    master - mean (101ms)  : 98, 104

    section Bailout
    This PR (7970) - mean (94ms)  : 92, 96
    master - mean (102ms)  : 100, 104

    section CallTarget+Inlining+NGEN
    This PR (7970) - mean (665ms)  : 643, 686
    master - mean (691ms)  : 667, 715

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7970) - mean (92ms)  : 90, 94
    master - mean (100ms)  : 97, 103

    section Bailout
    This PR (7970) - mean (93ms)  : 92, 95
    master - mean (101ms)  : 99, 103

    section CallTarget+Inlining+NGEN
    This PR (7970) - mean (632ms)  : 611, 652
    master - mean (660ms)  : 636, 683

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7970) - mean (193ms)  : 190, 197
    master - mean (193ms)  : 190, 197

    section Bailout
    This PR (7970) - mean (196ms)  : 194, 199
    master - mean (198ms)  : 195, 200

    section CallTarget+Inlining+NGEN
    This PR (7970) - mean (1,118ms)  : 1060, 1175
    master - mean (1,116ms)  : 1058, 1174

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7970) - mean (277ms)  : 273, 281
    master - mean (277ms)  : 272, 281

    section Bailout
    This PR (7970) - mean (278ms)  : 273, 282
    master - mean (277ms)  : 273, 282

    section CallTarget+Inlining+NGEN
    This PR (7970) - mean (910ms)  : 871, 950
    master - mean (905ms)  : 866, 945

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7970) - mean (270ms)  : 266, 274
    master - mean (271ms)  : 265, 276

    section Bailout
    This PR (7970) - mean (270ms)  : 267, 274
    master - mean (270ms)  : 265, 275

    section CallTarget+Inlining+NGEN
    This PR (7970) - mean (896ms)  : 854, 937
    master - mean (888ms)  : 847, 928

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7970) - mean (271ms)  : 265, 277
    master - mean (270ms)  : 260, 280

    section Bailout
    This PR (7970) - mean (269ms)  : 266, 273
    master - mean (268ms)  : 264, 272

    section CallTarget+Inlining+NGEN
    This PR (7970) - mean (825ms)  : 799, 851
    master - mean (819ms)  : 797, 842

Loading

@chrisnas chrisnas requested a review from a team as a code owner December 18, 2025 14:56
@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2025

Benchmarks

Benchmark execution time: 2025-12-18 15:59:33

Comparing candidate commit b159a65 in PR branch chrisnas/update_benchmarks with baseline commit ec4f411 in branch master.

Found 11 performance improvements and 8 performance regressions! Performance is the same for 155 metrics, 12 unstable metrics.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟩 execution_time [-19.537ms; -12.469ms] or [-9.097%; -5.806%]
  • 🟩 throughput [+7853.978op/s; +10941.820op/s] or [+8.970%; +12.496%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+83.331ms; +83.515ms] or [+69.049%; +69.202%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.564ms; -12.261ms] or [-8.825%; -5.829%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟩 execution_time [-19.421ms; -19.007ms] or [-9.673%; -9.467%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟥 throughput [-387.984op/s; -212.345op/s] or [-17.122%; -9.371%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟩 throughput [+82.871op/s; +102.526op/s] or [+8.381%; +10.369%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

  • 🟩 execution_time [-135.846µs; -131.367µs] or [-6.623%; -6.404%]
  • 🟩 throughput [+33.407op/s; +34.524op/s] or [+6.852%; +7.082%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟩 execution_time [-99.430µs; -94.530µs] or [-6.439%; -6.122%]
  • 🟩 throughput [+42.300op/s; +44.488op/s] or [+6.532%; +6.870%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟥 execution_time [+151.322µs; +205.825µs] or [+7.890%; +10.732%]
  • 🟥 throughput [-50.059op/s; -38.223op/s] or [-9.601%; -7.331%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟥 throughput [-1341.654op/s; -1175.913op/s] or [-68.028%; -59.624%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟥 throughput [-498.281op/s; -293.857op/s] or [-23.007%; -13.568%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 throughput [-2881.871op/s; -1195.809op/s] or [-13.159%; -5.460%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 execution_time [-18.973ms; -14.167ms] or [-8.815%; -6.582%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟥 execution_time [+13.426ms; +17.514ms] or [+6.825%; +8.903%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 execution_time [-20.769ms; -16.577ms] or [-9.515%; -7.594%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:profiler Issues related to the continous-profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants