Skip to content

Skip flaky debugger tests on x86 #7023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Skip flaky debugger tests on x86 #7023

merged 1 commit into from
May 28, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

Skips the LiveDebugger tests on x86 as they hang

Reason for change

The tests very frequently hang on x86 on .NET 8 and .NET 9. Tried to mitigate in #7010, but that apparently didn't work.

Implementation details

Skip the tests explicitly on x86 on .NET 8+

Test coverage

Less now, but hopefully also less flake

@andrewlock andrewlock requested a review from a team as a code owner May 28, 2025 11:37
@github-actions github-actions bot added the area:tests unit tests, integration tests label May 28, 2025
@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7023) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 66, 69
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7023) - mean (1,006ms)  : 978, 1033
     .   : milestone, 1006,
    master - mean (1,008ms)  : 984, 1032
     .   : milestone, 1008,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7023) - mean (102ms)  : 99, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7023) - mean (693ms)  : 672, 714
     .   : milestone, 693,
    master - mean (692ms)  : 676, 708
     .   : milestone, 692,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7023) - mean (89ms)  : 87, 90
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7023) - mean (648ms)  : 629, 667
     .   : milestone, 648,
    master - mean (657ms)  : 633, 681
     .   : milestone, 657,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7023) - mean (189ms)  : 185, 193
     .   : milestone, 189,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7023) - mean (1,112ms)  : 1084, 1140
     .   : milestone, 1112,
    master - mean (1,112ms)  : 1084, 1140
     .   : milestone, 1112,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7023) - mean (269ms)  : 265, 273
     .   : milestone, 269,
    master - mean (269ms)  : 264, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7023) - mean (876ms)  : 838, 914
     .   : milestone, 876,
    master - mean (878ms)  : 849, 907
     .   : milestone, 878,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7023) - mean (261ms)  : 258, 264
     .   : milestone, 261,
    master - mean (261ms)  : 259, 264
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (7023) - mean (868ms)  : 837, 899
     .   : milestone, 868,
    master - mean (868ms)  : 829, 907
     .   : milestone, 868,
Loading

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 28, 2025 •
edited
Loading

Datadog Report

All test runs e59f100 🔗

❌ 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 1 0 0 255337 6497 39h 50m 36.98s Link
exploration_tests 0 0 0 7433 0 10m 22.01s Link

❌ Failed Tests (1)

  • MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error 
     Connection refused (127.0.0.1:36201)
 ---- System.Net.Http.HttpRequestException : Connection refused (127.0.0.1:36201)
 -------- System.Net.Sockets.SocketException : Connection refused

@pr-commenter
Copy link

pr-commenter bot commented May 28, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7023 compared to master:

  • All benchmarks have the same speed
  • 4 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.3μs 46.1ns 172ns 0 0 0 5.56 KB
master StartStopWithChild netcoreapp3.1 13.3μs 70.2ns 344ns 0 0 0 5.75 KB
master StartStopWithChild net472 21.8μs 102ns 393ns 0.96 0.24 0 6.14 KB
#7023 StartStopWithChild net6.0 10.9μs 58ns 312ns 0 0 0 5.54 KB
#7023 StartStopWithChild netcoreapp3.1 13.3μs 67.4ns 294ns 0 0 0 5.74 KB
#7023 StartStopWithChild net472 22.5μs 124ns 747ns 1.05 0.316 0.105 6.14 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7023

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.35 KB 23 B 0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 921μs 81.6ns 294ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.05ms 63.7ns 221ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 73.2ns 283ns 0 0 0 3.33 KB
#7023 WriteAndFlushEnrichedTraces net6.0 933μs 62.3ns 233ns 0 0 0 2.7 KB
#7023 WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 107ns 401ns 0 0 0 2.7 KB
#7023 WriteAndFlushEnrichedTraces net472 1.22ms 284ns 1.1μs 0 0 0 3.35 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 560ns 2.17μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 485μs 1.98μs 7.68μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 437μs 211ns 818ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 337μs 999ns 3.6μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 488μs 2.22μs 9.15μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 445μs 164ns 615ns 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 314ns 1.56ns 7.15ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 392ns 2.16ns 10.8ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.0307ns 0.115ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.27μs 14.1ns 54.5ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 38ns 152ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.67μs 1.73ns 6.69ns 0.6 0 0 3.8 KB
#7023 AllCycleSimpleBody net6.0 330μs 1.57μs 6.07μs 0 0 0 197.06 KB
#7023 AllCycleSimpleBody netcoreapp3.1 507μs 204ns 789ns 0 0 0 204.77 KB
#7023 AllCycleSimpleBody net472 437μs 101ns 390ns 36.6 2.16 0 236.35 KB
#7023 AllCycleMoreComplexBody net6.0 338μs 209ns 809ns 0 0 0 200.56 KB
#7023 AllCycleMoreComplexBody netcoreapp3.1 492μs 2.03μs 7.6μs 0 0 0 208.18 KB
#7023 AllCycleMoreComplexBody net472 444μs 137ns 532ns 36.6 2.16 0 239.87 KB
#7023 ObjectExtractorSimpleBody net6.0 320ns 1.77ns 11.1ns 0 0 0 280 B
#7023 ObjectExtractorSimpleBody netcoreapp3.1 403ns 1.97ns 8.12ns 0 0 0 272 B
#7023 ObjectExtractorSimpleBody net472 304ns 0.0254ns 0.0949ns 0.0441 0 0 281 B
#7023 ObjectExtractorMoreComplexBody net6.0 6.29μs 32.4ns 152ns 0 0 0 3.78 KB
#7023 ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 27.7ns 107ns 0 0 0 3.69 KB
#7023 ObjectExtractorMoreComplexBody net472 6.66μs 2ns 7.74ns 0.602 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#7023 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7023 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7023 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#7023 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7023 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7023 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#7023 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7023 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7023 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#7023 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7023 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7023 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7023

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 14.62 KB 14.53 KB -90 B -0.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 62.1μs 246ns 919ns 0 0 0 14.62 KB
master SendRequest netcoreapp3.1 72.5μs 77ns 278ns 0 0 0 17.42 KB
master SendRequest net472 0.0113ns 0.0018ns 0.00672ns 0 0 0 0 b
#7023 SendRequest net6.0 62.3μs 168ns 652ns 0 0 0 14.53 KB
#7023 SendRequest netcoreapp3.1 71.6μs 64.3ns 249ns 0 0 0 17.43 KB
#7023 SendRequest net472 0.021ns 0.00172ns 0.00668ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7023

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.21 KB 42.47 KB 266 B 0.63%

Fewer allocations 🎉 in #7023

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.25 KB 55.96 KB -290 B -0.52%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 655μs 614ns 2.38μs 0 0 0 41.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.94μs 33.7μs 0 0 0 42.21 KB
master WriteAndFlushEnrichedTraces net472 934μs 4.21μs 16.3μs 8.33 0 0 56.25 KB
#7023 WriteAndFlushEnrichedTraces net6.0 724μs 1.55μs 6μs 0 0 0 41.77 KB
#7023 WriteAndFlushEnrichedTraces netcoreapp3.1 687μs 5.2μs 51.7μs 0 0 0 42.47 KB
#7023 WriteAndFlushEnrichedTraces net472 956μs 3.03μs 11.7μs 4.46 0 0 55.96 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 5.74ns 22.2ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.45μs 11.8ns 50.2ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.87μs 2.6ns 10.1ns 0.144 0.0144 0 995 B
#7023 ExecuteNonQuery net6.0 1.82μs 8.83ns 38.5ns 0 0 0 1.03 KB
#7023 ExecuteNonQuery netcoreapp3.1 2.45μs 6.9ns 26.7ns 0 0 0 1.02 KB
#7023 ExecuteNonQuery net472 2.7μs 1.84ns 7.14ns 0.148 0.0134 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.78μs 3.42ns 13.2ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.2μs 10.3ns 42.5ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.54μs 5.44ns 21.1ns 0.158 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.83μs 9.39ns 44ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.41μs 11.2ns 44.6ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.63μs 1.59ns 5.95ns 0.164 0 0 1.11 KB
#7023 CallElasticsearch net6.0 1.69μs 8.52ns 37.2ns 0 0 0 1.04 KB
#7023 CallElasticsearch netcoreapp3.1 2.22μs 9.18ns 35.5ns 0 0 0 1.04 KB
#7023 CallElasticsearch net472 3.64μs 3.01ns 11.7ns 0.164 0 0 1.05 KB
#7023 CallElasticsearchAsync net6.0 1.88μs 8.42ns 32.6ns 0 0 0 1.02 KB
#7023 CallElasticsearchAsync netcoreapp3.1 2.39μs 8.93ns 34.6ns 0 0 0 1.09 KB
#7023 CallElasticsearchAsync net472 3.72μs 4.81ns 18.6ns 0.165 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.8μs 1.57ns 6.1ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.37μs 8.31ns 32.2ns 0 0 0 960 B
master ExecuteAsync net472 2.62μs 3.11ns 12ns 0.144 0 0 923 B
#7023 ExecuteAsync net6.0 1.8μs 2.52ns 9.08ns 0 0 0 960 B
#7023 ExecuteAsync netcoreapp3.1 2.37μs 8.26ns 32ns 0 0 0 960 B
#7023 ExecuteAsync net472 2.62μs 2.02ns 7.55ns 0.144 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.76μs 14.6ns 56.5ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.62μs 9.8ns 38ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 9.38ns 35.1ns 0.491 0 0 3.19 KB
#7023 SendAsync net6.0 6.81μs 7.62ns 28.5ns 0 0 0 2.37 KB
#7023 SendAsync netcoreapp3.1 8.24μs 26.3ns 102ns 0 0 0 2.9 KB
#7023 SendAsync net472 12.1μs 10.5ns 40.7ns 0.484 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7023

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 259.16 KB 278.31 KB 19.15 KB 7.39%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.51 KB 45.84 KB 2.33 KB 5.35%

Fewer allocations 🎉 in #7023

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 278.74 KB 277.22 KB -1.52 KB -0.55%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 44.1 KB 42.78 KB -1.32 KB -2.99%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 45.1μs 259ns 1.78μs 0 0 0 43.51 KB
master StringConcatBenchmark netcoreapp3.1 47.7μs 184ns 665ns 0 0 0 44.1 KB
master StringConcatBenchmark net472 56.7μs 258ns 1.03μs 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 489μs 1.15μs 3.97μs 0 0 0 278.74 KB
master StringConcatAspectBenchmark netcoreapp3.1 536μs 1.36μs 5.09μs 0 0 0 259.16 KB
master StringConcatAspectBenchmark net472 408μs 2.35μs 18.5μs 0 0 0 278.53 KB
#7023 StringConcatBenchmark net6.0 45.3μs 296ns 2.76μs 0 0 0 45.84 KB
#7023 StringConcatBenchmark netcoreapp3.1 48.6μs 353ns 3.37μs 0 0 0 42.78 KB
#7023 StringConcatBenchmark net472 57.3μs 141ns 510ns 0 0 0 57.34 KB
#7023 StringConcatAspectBenchmark net6.0 507μs 1.54μs 5.54μs 0 0 0 277.22 KB
#7023 StringConcatAspectBenchmark netcoreapp3.1 554μs 2.19μs 8.18μs 0 0 0 278.31 KB
#7023 StringConcatAspectBenchmark net472 403μs 2.31μs 18.9μs 0 0 0 277.23 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 3.11ns 12ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.45μs 4.11ns 15.9ns 0 0 0 1.76 KB
master EnrichedLog net472 3.87μs 2.6ns 10.1ns 0.251 0 0 1.69 KB
#7023 EnrichedLog net6.0 2.53μs 13.2ns 70.1ns 0 0 0 1.76 KB
#7023 EnrichedLog netcoreapp3.1 3.46μs 17.1ns 78.6ns 0 0 0 1.76 KB
#7023 EnrichedLog net472 3.78μs 2.79ns 10.8ns 0.264 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 96.3ns 333ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 127μs 80.6ns 301ns 0 0 0 4.37 KB
master EnrichedLog net472 168μs 210ns 814ns 0 0 0 4.57 KB
#7023 EnrichedLog net6.0 122μs 82.6ns 298ns 0 0 0 4.37 KB
#7023 EnrichedLog netcoreapp3.1 126μs 45.2ns 169ns 0 0 0 4.37 KB
#7023 EnrichedLog net472 168μs 112ns 434ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.91μs 5.54ns 20.7ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.57μs 19.8ns 76.6ns 0 0 0 2.32 KB
master EnrichedLog net472 7.27μs 7.3ns 28.3ns 0.325 0 0 2.14 KB
#7023 EnrichedLog net6.0 5.19μs 2.5ns 9.01ns 0 0 0 2.32 KB
#7023 EnrichedLog netcoreapp3.1 6.79μs 10.5ns 40.6ns 0 0 0 2.32 KB
#7023 EnrichedLog net472 7.59μs 8.82ns 34.2ns 0.34 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.06μs 2.54ns 9.82ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.59μs 13.2ns 57.7ns 0 0 0 1.21 KB
master SendReceive net472 3.02μs 4.81ns 18.6ns 0.182 0 0 1.21 KB
#7023 SendReceive net6.0 1.96μs 7.47ns 26.9ns 0 0 0 1.21 KB
#7023 SendReceive netcoreapp3.1 2.63μs 11.1ns 39.9ns 0 0 0 1.21 KB
#7023 SendReceive net472 3μs 1.8ns 6.98ns 0.18 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.09μs 4.14ns 15.5ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.62μs 5.07ns 19ns 0 0 0 1.69 KB
master EnrichedLog net472 6.59μs 8.33ns 32.3ns 0.328 0 0 2.08 KB
#7023 EnrichedLog net6.0 4.34μs 12.6ns 48.9ns 0 0 0 1.64 KB
#7023 EnrichedLog netcoreapp3.1 5.65μs 3.76ns 13.6ns 0 0 0 1.69 KB
#7023 EnrichedLog net472 6.54μs 11.8ns 45.8ns 0.326 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 737ns 4.06ns 24.7ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 967ns 0.621ns 2.4ns 0 0 0 584 B
master StartFinishSpan net472 910ns 0.106ns 0.41ns 0.091 0 0 586 B
master StartFinishScope net6.0 926ns 4.56ns 18.8ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.18μs 5.29ns 20.5ns 0 0 0 704 B
master StartFinishScope net472 1.14μs 0.134ns 0.518ns 0.103 0 0 666 B
#7023 StartFinishSpan net6.0 754ns 0.516ns 1.93ns 0 0 0 584 B
#7023 StartFinishSpan netcoreapp3.1 953ns 4.78ns 21.9ns 0 0 0 584 B
#7023 StartFinishSpan net472 894ns 0.242ns 0.906ns 0.0895 0 0 586 B
#7023 StartFinishScope net6.0 918ns 4.34ns 16.8ns 0 0 0 704 B
#7023 StartFinishScope netcoreapp3.1 1.15μs 1.84ns 7.12ns 0 0 0 704 B
#7023 StartFinishScope net472 1.15μs 0.348ns 1.35ns 0.102 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 1.12ns 4.04ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.34μs 5.3ns 20.5ns 0 0 0 704 B
master RunOnMethodBegin net472 1.34μs 1.47ns 5.69ns 0.101 0 0 666 B
#7023 RunOnMethodBegin net6.0 1.02μs 4.66ns 18.1ns 0 0 0 704 B
#7023 RunOnMethodBegin netcoreapp3.1 1.39μs 5.55ns 21.5ns 0 0 0 704 B
#7023 RunOnMethodBegin net472 1.38μs 0.661ns 2.56ns 0.105 0 0 666 B

@andrewlock andrewlock merged commit c2255e0 into master May 28, 2025
129 of 132 checks passed
@andrewlock andrewlock deleted the andrew/ci/skip-debugger-tests-2 branch May 28, 2025 13:04
@github-actions github-actions bot added this to the vNext-v3 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudikeleti dudikeleti dudikeleti approved these changes

Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @dudikeleti