Skip to content

Revert "Benchmarks: Update microbenchmarks to customize BenchmarkDotNet command line arguments" #7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

Revert "Benchmarks: Update microbenchmarks to customize BenchmarkDotNet command line arguments" #7016

merged 1 commit into from
May 27, 2025

Conversation

zacharycmontoya
Copy link
Contributor

@zacharycmontoya zacharycmontoya commented May 27, 2025 •
edited
Loading

Summary of changes

Reverts #6990

This reverts commit 95ee281.

Reason for change

The iteration time that was updated in the previous change caused instability in the OpenTelemetry Tracing API benchmarks and other issues with collecting Benchmarks.Trace results.

Implementation details

Test coverage

Other details

@zacharycmontoya zacharycmontoya requested a review from a team as a code owner May 27, 2025 16:24
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label May 27, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 27, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #99 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.263
  • 6 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.53 KB 5.56 KB 35 B 0.63%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.5μs 54.3ns 272ns 0 0 0 5.53 KB
master StartStopWithChild netcoreapp3.1 13μs 68.3ns 348ns 0 0 0 5.76 KB
master StartStopWithChild net472 22.4μs 122ns 743ns 1.08 0.323 0.108 6.12 KB
#99 StartStopWithChild net6.0 10.3μs 57.7ns 374ns 0 0 0 5.56 KB
#99 StartStopWithChild netcoreapp3.1 13.7μs 66.1ns 256ns 0 0 0 5.75 KB
#99 StartStopWithChild net472 21.4μs 119ns 762ns 1.01 0.337 0.112 6.15 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 928μs 50.3ns 195ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.05ms 92.7ns 334ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.22ms 739ns 2.86μs 0 0 0 3.31 KB
#99 WriteAndFlushEnrichedTraces net6.0 927μs 281ns 1.09μs 0 0 0 2.7 KB
#99 WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 303ns 1.17μs 0 0 0 2.7 KB
#99 WriteAndFlushEnrichedTraces net472 1.22ms 48.8ns 176ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 239.11 KB 237.91 KB -1.2 KB -0.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 332μs 1.24μs 4.82μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 484μs 333ns 1.25μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 438μs 107ns 415ns 36.6 2.16 0 239.11 KB
master AllCycleMoreComplexBody net6.0 338μs 1.53μs 5.92μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 481μs 2.27μs 8.8μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 448μs 71.4ns 267ns 37.9 2.23 0 242.62 KB
master ObjectExtractorSimpleBody net6.0 322ns 0.182ns 0.704ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 397ns 1.91ns 8.09ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 301ns 0.0367ns 0.132ns 0.0439 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.35μs 29ns 112ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.74μs 22.9ns 88.7ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.67μs 3.8ns 13.7ns 0.602 0 0 3.8 KB
#99 AllCycleSimpleBody net6.0 334μs 968ns 3.75μs 0 0 0 197.06 KB
#99 AllCycleSimpleBody netcoreapp3.1 495μs 2.31μs 9.23μs 0 0 0 204.77 KB
#99 AllCycleSimpleBody net472 439μs 174ns 675ns 36.6 2.16 0 237.91 KB
#99 AllCycleMoreComplexBody net6.0 346μs 1.06μs 4.11μs 0 0 0 200.56 KB
#99 AllCycleMoreComplexBody netcoreapp3.1 496μs 1.44μs 5.58μs 0 0 0 208.18 KB
#99 AllCycleMoreComplexBody net472 446μs 88.7ns 320ns 37.9 2.23 0 241.41 KB
#99 ObjectExtractorSimpleBody net6.0 313ns 0.347ns 1.34ns 0 0 0 280 B
#99 ObjectExtractorSimpleBody netcoreapp3.1 392ns 2.18ns 12.9ns 0 0 0 272 B
#99 ObjectExtractorSimpleBody net472 302ns 0.0139ns 0.052ns 0.0444 0 0 281 B
#99 ObjectExtractorMoreComplexBody net6.0 6.4μs 29.4ns 118ns 0 0 0 3.78 KB
#99 ObjectExtractorMoreComplexBody netcoreapp3.1 7.77μs 27ns 105ns 0 0 0 3.69 KB
#99 ObjectExtractorMoreComplexBody net472 6.71μs 8.61ns 33.3ns 0.602 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.8μs 54.2ns 195ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 71.8μs 350ns 1.53μs 0 0 0 17.5 KB
master SendRequest net472 0.0128ns 0.00273ns 0.0106ns 0 0 0 0 b
#99 SendRequest net6.0 61.2μs 94.2ns 352ns 0 0 0 14.53 KB
#99 SendRequest netcoreapp3.1 71.4μs 188ns 727ns 0 0 0 17.42 KB
#99 SendRequest net472 0.00213ns 0.00103ns 0.00399ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.41 KB 41.76 KB -650 B -1.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 719μs 5μs 49.5μs 0 0 0 42.41 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 722μs 3.53μs 14.1μs 0 0 0 41.85 KB
master WriteAndFlushEnrichedTraces net472 932μs 2.21μs 8.25μs 8.33 0 0 56.32 KB
#99 WriteAndFlushEnrichedTraces net6.0 729μs 4.18μs 31.8μs 0 0 0 41.76 KB
#99 WriteAndFlushEnrichedTraces netcoreapp3.1 746μs 3.78μs 18.1μs 0 0 0 41.9 KB
#99 WriteAndFlushEnrichedTraces net472 868μs 2.59μs 9.69μs 8.33 0 0 56.08 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 1.92ns 7.42ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.51μs 8.12ns 31.5ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.74μs 4.12ns 15.9ns 0.151 0.0137 0 995 B
#99 ExecuteNonQuery net6.0 1.96μs 1.27ns 4.74ns 0 0 0 1.03 KB
#99 ExecuteNonQuery netcoreapp3.1 2.43μs 3.72ns 13.9ns 0 0 0 1.02 KB
#99 ExecuteNonQuery net472 2.77μs 4.06ns 15.7ns 0.152 0.0138 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.74μs 8.59ns 35.4ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.29μs 7.36ns 28.5ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.5μs 0.963ns 3.6ns 0.158 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.77μs 8.63ns 35.6ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.38μs 11.9ns 48.9ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.85μs 5.98ns 23.1ns 0.172 0 0 1.11 KB
#99 CallElasticsearch net6.0 1.85μs 8.29ns 31ns 0 0 0 1.04 KB
#99 CallElasticsearch netcoreapp3.1 2.32μs 11.1ns 43ns 0 0 0 1.04 KB
#99 CallElasticsearch net472 3.53μs 5.38ns 20.8ns 0.161 0 0 1.05 KB
#99 CallElasticsearchAsync net6.0 1.79μs 9.13ns 39.8ns 0 0 0 1.02 KB
#99 CallElasticsearchAsync netcoreapp3.1 2.44μs 3.26ns 11.7ns 0 0 0 1.09 KB
#99 CallElasticsearchAsync net472 3.65μs 1.86ns 6.72ns 0.165 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.75μs 9.41ns 42.1ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.34μs 6.47ns 24.2ns 0 0 0 960 B
master ExecuteAsync net472 2.61μs 6.29ns 23.5ns 0.145 0 0 923 B
#99 ExecuteAsync net6.0 1.79μs 0.943ns 3.53ns 0 0 0 960 B
#99 ExecuteAsync netcoreapp3.1 2.27μs 9.58ns 37.1ns 0 0 0 960 B
#99 ExecuteAsync net472 2.55μs 2.52ns 9.76ns 0.141 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7μs 7.61ns 28.5ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.53μs 10.6ns 41.1ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 39.9ns 0.497 0 0 3.19 KB
#99 SendAsync net6.0 6.84μs 18.5ns 71.6ns 0 0 0 2.37 KB
#99 SendAsync netcoreapp3.1 8.56μs 11.2ns 43.2ns 0 0 0 2.9 KB
#99 SendAsync net472 12.7μs 7.23ns 28ns 0.444 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #99

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.263 387,650.00 489,700.00

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 256.12 KB 276.4 KB 20.28 KB 7.92%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.74 KB 284.57 KB 5.83 KB 2.09%

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.86 KB 43.1 KB -760 B -1.73%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 257.93 KB 249.32 KB -8.61 KB -3.34%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 45.13 KB 42.76 KB -2.37 KB -5.25%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 254ns 2μs 0 0 0 43.86 KB
master StringConcatBenchmark netcoreapp3.1 48.8μs 283ns 2.11μs 0 0 0 45.13 KB
master StringConcatBenchmark net472 57.2μs 171ns 639ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 399μs 2.51μs 22.6μs 0 0 0 256.12 KB
master StringConcatAspectBenchmark netcoreapp3.1 518μs 2.5μs 9.99μs 0 0 0 257.93 KB
master StringConcatAspectBenchmark net472 409μs 2.15μs 10.5μs 0 0 0 278.74 KB
#99 StringConcatBenchmark net6.0 45μs 257ns 1.85μs 0 0 0 43.1 KB
#99 StringConcatBenchmark netcoreapp3.1 50.1μs 290ns 2.73μs 0 0 0 42.76 KB
#99 StringConcatBenchmark net472 58.2μs 190ns 712ns 0 0 0 57.34 KB
#99 StringConcatAspectBenchmark net6.0 494μs 2.38μs 9.23μs 0 0 0 276.4 KB
#99 StringConcatAspectBenchmark netcoreapp3.1 504μs 2.4μs 9.9μs 0 0 0 249.32 KB
#99 StringConcatAspectBenchmark net472 411μs 2.13μs 9.75μs 0 0 0 284.57 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.66μs 1.9ns 7.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 14.3ns 55.4ns 0 0 0 1.76 KB
master EnrichedLog net472 3.86μs 4.57ns 17.7ns 0.252 0 0 1.69 KB
#99 EnrichedLog net6.0 2.6μs 3.82ns 13.8ns 0 0 0 1.76 KB
#99 EnrichedLog netcoreapp3.1 3.5μs 7.94ns 30.8ns 0 0 0 1.76 KB
#99 EnrichedLog net472 3.85μs 2.51ns 9.71ns 0.251 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 44.1ns 159ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 60.7ns 235ns 0 0 0 4.37 KB
master EnrichedLog net472 165μs 48.3ns 187ns 0 0 0 4.57 KB
#99 EnrichedLog net6.0 124μs 51.5ns 193ns 0 0 0 4.37 KB
#99 EnrichedLog netcoreapp3.1 128μs 207ns 774ns 0 0 0 4.37 KB
#99 EnrichedLog net472 167μs 30.8ns 115ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.09μs 11.2ns 43.2ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.51μs 26.8ns 104ns 0 0 0 2.32 KB
master EnrichedLog net472 7.34μs 9.01ns 34.9ns 0.329 0 0 2.14 KB
#99 EnrichedLog net6.0 4.93μs 19.5ns 75.5ns 0 0 0 2.32 KB
#99 EnrichedLog netcoreapp3.1 6.65μs 16.9ns 65.6ns 0 0 0 2.32 KB
#99 EnrichedLog net472 7.32μs 5.47ns 21.2ns 0.328 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.07μs 3.23ns 12.5ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.58μs 12.6ns 50.3ns 0 0 0 1.21 KB
master SendReceive net472 3.03μs 2.28ns 8.81ns 0.181 0 0 1.21 KB
#99 SendReceive net6.0 1.96μs 1.43ns 5.54ns 0 0 0 1.21 KB
#99 SendReceive netcoreapp3.1 2.57μs 9.15ns 35.4ns 0 0 0 1.21 KB
#99 SendReceive net472 3.06μs 4.62ns 17.9ns 0.183 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.2μs 14.4ns 55.8ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.68μs 5.88ns 22ns 0 0 0 1.69 KB
master EnrichedLog net472 6.53μs 7.87ns 30.5ns 0.324 0 0 2.08 KB
#99 EnrichedLog net6.0 4.37μs 4.36ns 16.9ns 0 0 0 1.64 KB
#99 EnrichedLog netcoreapp3.1 5.7μs 21.4ns 82.9ns 0 0 0 1.69 KB
#99 EnrichedLog net472 6.53μs 6.84ns 25.6ns 0.328 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 755ns 0.381ns 1.43ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 939ns 4.93ns 25.1ns 0 0 0 584 B
master StartFinishSpan net472 918ns 0.275ns 1.06ns 0.0927 0 0 586 B
master StartFinishScope net6.0 919ns 4.94ns 25.2ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.16μs 6.23ns 36.3ns 0 0 0 704 B
master StartFinishScope net472 1.12μs 0.268ns 1ns 0.101 0 0 666 B
#99 StartFinishSpan net6.0 770ns 1.73ns 6.47ns 0 0 0 584 B
#99 StartFinishSpan netcoreapp3.1 941ns 3.94ns 14.7ns 0 0 0 584 B
#99 StartFinishSpan net472 913ns 0.236ns 0.882ns 0.0915 0 0 586 B
#99 StartFinishScope net6.0 930ns 4.16ns 16.1ns 0 0 0 704 B
#99 StartFinishScope netcoreapp3.1 1.17μs 5.84ns 24.8ns 0 0 0 704 B
#99 StartFinishScope net472 1.13μs 0.241ns 0.934ns 0.102 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.01μs 4.84ns 19.9ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.37μs 6.35ns 25.4ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 3.67ns 14.2ns 0.102 0 0 666 B
#99 RunOnMethodBegin net6.0 1.04μs 1.38ns 5.34ns 0 0 0 704 B
#99 RunOnMethodBegin netcoreapp3.1 1.32μs 7ns 37.1ns 0 0 0 704 B
#99 RunOnMethodBegin net472 1.37μs 1.8ns 6.96ns 0.102 0 0 666 B

andrewlock
andrewlock approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand why this didn't work but 🙈

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7016) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7016) - mean (1,008ms)  : 987, 1029
     .   : milestone, 1008,
    master - mean (1,009ms)  : 980, 1037
     .   : milestone, 1009,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7016) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7016) - mean (693ms)  : 675, 712
     .   : milestone, 693,
    master - mean (691ms)  : 670, 713
     .   : milestone, 691,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7016) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 90
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7016) - mean (658ms)  : 630, 686
     .   : milestone, 658,
    master - mean (657ms)  : 635, 679
     .   : milestone, 657,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7016) - mean (190ms)  : 183, 197
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7016) - mean (1,112ms)  : 1081, 1143
     .   : milestone, 1112,
    master - mean (1,118ms)  : 1066, 1170
     .   : milestone, 1118,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7016) - mean (269ms)  : 265, 272
     .   : milestone, 269,
    master - mean (269ms)  : 265, 272
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7016) - mean (876ms)  : 853, 898
     .   : milestone, 876,
    master - mean (876ms)  : 848, 904
     .   : milestone, 876,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7016) - mean (261ms)  : 258, 264
     .   : milestone, 261,
    master - mean (262ms)  : 259, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7016) - mean (867ms)  : 837, 897
     .   : milestone, 867,
    master - mean (869ms)  : 841, 898
     .   : milestone, 869,
Loading

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 27, 2025 •
edited
Loading

Datadog Report

Branch report: zach.montoya/revert-benchmarks-update
Commit report: d4881af
Test service: dd-trace-dotnet

✅ 0 Failed, 255051 Passed, 2350 Skipped, 15h 17m 33.08s Total Time

@zacharycmontoya zacharycmontoya merged commit 7e76ecb into master May 27, 2025
65 of 68 checks passed
@zacharycmontoya zacharycmontoya deleted the zach.montoya/revert-benchmarks-update branch May 27, 2025 17:55
@github-actions github-actions bot added this to the vNext-v3 milestone May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharycmontoya @andrewlock @lucaspimentel