Skip to content

[SDS-1412] Richer error string on AWS Failure #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachchentouf merged 1 commit into from
Sep 10, 2025
Merged

[SDS-1412] Richer error string on AWS Failure #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions sds/src/match_validation/aws_validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use std::error::Error as StdError;
use std::fmt;

use super::{
Expand Down Expand Up @@ -164,9 +165,19 @@ impl MatchValidator for AwsValidator {
match res {
Ok(val) => handle_reqwest_response(match_status, &val),
Err(err) => {
*match_status = MatchStatus::Error(fmt::format(format_args!(
"Error making HTTP request: {err}"
)));
let mut msg = format!("Error making HTTP request: {err}");
if err.is_timeout() {
msg.push_str(": timeout");
} else if err.is_connect() {
msg.push_str(": connect error");
}
if let Some(status) = err.status() {
msg.push_str(format!(": status {}", status.as_u16()).as_str());
}
if let Some(source) = StdError::source(&err) {
msg.push_str(format!(": {}", source).as_str());
}
*match_status = MatchStatus::Error(msg);
}
};
});
Expand Down