Skip to content

Conversation

@0xnm
Copy link
Member

@0xnm 0xnm commented Sep 11, 2025

What does this PR do?

A bug squeezed in b95e0d7, breaking a proper Gradle version check.

As a result, with Gradle 9.0 the method to mark tasks as not compatible with configuration cache wasn't executed, because 9.0 >= 8.4 was returning false.

This PR does a proper bugfix.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners September 11, 2025 15:06
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.39%. Comparing base (35ea57c) to head (a59d190).

Files with missing lines Patch % Lines
...atadog/gradle/plugin/internal/CurrentAgpVersion.kt 50.00% 2 Missing ⚠️
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #435      +/-   ##
=============================================
+ Coverage      75.78%   76.39%   +0.61%     
- Complexity       278      286       +8     
=============================================
  Files             35       35              
  Lines           1057     1063       +6     
  Branches         129      130       +1     
=============================================
+ Hits             801      812      +11     
+ Misses           195      194       -1     
+ Partials          61       57       -4     
Files with missing lines Coverage Δ
...main/kotlin/com/datadog/gradle/plugin/TaskUtils.kt 89.29% <100.00%> (+12.01%) ⬆️
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 59.09% <0.00%> (ø)
...atadog/gradle/plugin/internal/CurrentAgpVersion.kt 50.00% <50.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm 0xnm merged commit bbcaba4 into develop Sep 15, 2025
14 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-11320/support-gradle-9.0 branch September 15, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants