Skip to content

Conversation

@ambushwork
Copy link
Member

What does this PR do?

Configure gradle file to create multiple source sets for Compiler Plugin.

This is the first step for adding the compatibility for different versions of Kotlin.

Motivation

RUM-11238

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork marked this pull request as ready for review August 6, 2025 13:58
@ambushwork ambushwork requested review from a team as code owners August 6, 2025 13:58
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.98%. Comparing base (f7c59b1) to head (7335b35).

Additional details and impacted files
@@                       Coverage Diff                        @@
##             feature/kotlin-source-sets     #412      +/-   ##
================================================================
- Coverage                         77.12%   76.98%   -0.15%     
+ Complexity                          347      343       -4     
================================================================
  Files                                42       42              
  Lines                              1377     1377              
  Branches                            168      168              
================================================================
- Hits                               1062     1060       -2     
  Misses                              220      220              
- Partials                             95       97       +2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork ambushwork merged commit 25890a8 into feature/kotlin-source-sets Aug 7, 2025
15 checks passed
@ambushwork ambushwork deleted the yl/build-up-source-sets branch August 7, 2025 15:43
Comment on lines +86 to +88
from(kotlin20.output)
from(kotlin21.output)
from(kotlin22.output)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means though that it will be a conflict if outputs contain files with the same (okay, paths), I'm not sure fat JAR is possible for such slicing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it will, that's why we name all the classes & files differently in each source sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants