Skip to content

Conversation

@ambushwork
Copy link
Member

What does this PR do?

Reference changes based on the PR

  • datadog -> instrumentedDatadog
  • NavigationViewTrackingEffect -> InstrumentedNavigationViewTrackingEffect

Additional Notes

Because Instrumented module depends on the release version of SDK for instrumented test, so it can not find the InstrumentedNavigationViewTrackingEffect API in current version of SDK, we need to wait to restore it until the API goes to public.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork force-pushed the yl/kcp/telemetry-call branch from 2e0ae6d to 14ea742 Compare April 16, 2025 09:49
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.19%. Comparing base (14cbd1a) to head (31f06f7).

Additional details and impacted files
@@                         Coverage Diff                          @@
##             feature/kotlin-compiler-plugin     #363      +/-   ##
====================================================================
+ Coverage                             77.04%   77.19%   +0.15%     
- Complexity                              345      346       +1     
====================================================================
  Files                                    41       41              
  Lines                                  1372     1372              
  Branches                                167      167              
====================================================================
+ Hits                                   1057     1059       +2     
  Misses                                  219      219              
+ Partials                                 96       94       -2     
Files with missing lines Coverage Δ
...dog/gradle/plugin/kcp/DefaultPluginContextUtils.kt 76.19% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork ambushwork force-pushed the yl/kcp/telemetry-call branch from 14ea742 to ec54216 Compare April 16, 2025 11:36
@ambushwork ambushwork marked this pull request as ready for review April 16, 2025 12:21
@ambushwork ambushwork requested review from a team as code owners April 16, 2025 12:21
0xnm
0xnm previously approved these changes Apr 16, 2025
@ambushwork ambushwork force-pushed the yl/kcp/telemetry-call branch 2 times, most recently from 2aee517 to 4d92a42 Compare April 16, 2025 13:27
@ambushwork ambushwork force-pushed the yl/kcp/telemetry-call branch from 4d92a42 to 31f06f7 Compare April 17, 2025 08:25
@ambushwork ambushwork merged commit 128d57d into feature/kotlin-compiler-plugin Apr 17, 2025
13 checks passed
@ambushwork ambushwork deleted the yl/kcp/telemetry-call branch April 17, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants