Skip to content

Conversation

@ambushwork
Copy link
Member

What does this PR do?

In dd-sdk-android, Session Replay Compose resolves the components differently based on the Semantics Role.
Prior to this PR, datadog modifier only add semantics tag to help the components merged into the tree, but Images still don't have a Role since the contentDescription can be absent.

This PR enriches the datadog modifier with a new argument isImageRole: Boolean, and kotlin compiler plugin will sca the component for Image, Icon or AsyncImage, then put true on this argument to append semantics role for the components.

Motivation

RUM-9088

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (a63e699) to head (af8db6f).
Report is 2 commits behind head on feature/kotlin-compiler-plugin.

Files with missing lines Patch % Lines
...datadog/gradle/plugin/kcp/ComposeTagTransformer.kt 68.42% 3 Missing and 3 partials ⚠️
...dog/gradle/plugin/kcp/DefaultPluginContextUtils.kt 66.67% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##             feature/kotlin-compiler-plugin     #334      +/-   ##
====================================================================
- Coverage                             78.19%   78.00%   -0.19%     
- Complexity                              331      345      +14     
====================================================================
  Files                                    42       42              
  Lines                                  1325     1350      +25     
  Branches                                154      159       +5     
====================================================================
+ Hits                                   1036     1053      +17     
- Misses                                  206      210       +4     
- Partials                                 83       87       +4     
Files with missing lines Coverage Δ
...dog/gradle/plugin/kcp/DefaultPluginContextUtils.kt 74.58% <66.67%> (-1.42%) ⬇️
...datadog/gradle/plugin/kcp/ComposeTagTransformer.kt 83.54% <68.42%> (-5.34%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork ambushwork marked this pull request as ready for review March 18, 2025 10:18
@ambushwork ambushwork requested review from a team as code owners March 18, 2025 10:18
@ambushwork ambushwork merged commit 2024a2e into feature/kotlin-compiler-plugin Mar 18, 2025
13 checks passed
@ambushwork ambushwork deleted the yl/kcp/add-image-semantics-role branch March 18, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants