-
Notifications
You must be signed in to change notification settings - Fork 15
RUM-8950: Implement Kotlin compiler plugin DSL configuration #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ad3f7ef to
7076fc0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/kotlin-compiler-plugin #330 +/- ##
====================================================================
- Coverage 78.26% 78.17% -0.09%
- Complexity 315 330 +15
====================================================================
Files 37 41 +4
Lines 1233 1315 +82
Branches 149 154 +5
====================================================================
+ Hits 965 1028 +63
- Misses 187 205 +18
- Partials 81 82 +1
🚀 New features to boost your workflow:
|
dd-sdk-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt
Outdated
Show resolved
Hide resolved
...-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/DdExtensionConfiguration.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/InstrumentationMode.kt
Outdated
Show resolved
Hide resolved
...radle-plugin/src/main/kotlin/com/datadog/gradle/plugin/kcp/CompilerExtensionConfiguration.kt
Show resolved
Hide resolved
...radle-plugin/src/main/kotlin/com/datadog/gradle/plugin/kcp/CompilerExtensionConfiguration.kt
Outdated
Show resolved
Hide resolved
...dk-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/kcp/DatadogIrExtension.kt
Show resolved
Hide resolved
...ndroid-gradle-plugin/src/test/kotlin/com/datadog/gradle/plugin/kcp/DatadogIrExtensionTest.kt
Outdated
Show resolved
Hide resolved
...ndroid-gradle-plugin/src/test/kotlin/com/datadog/gradle/plugin/kcp/DatadogIrExtensionTest.kt
Outdated
Show resolved
Hide resolved
fb19a29 to
6eda9f4
Compare
6eda9f4 to
3f5add2
Compare
0xnm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! I've left few suggestion, mainly to remove mention of "Kotlin Compiler" plugin from the public docs, because for the end-user it is just a single plugin (Gradle plugin) who does the job.
dd-sdk-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt
Show resolved
Hide resolved
...-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/DdExtensionConfiguration.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/InstrumentationMode.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/InstrumentationMode.kt
Outdated
Show resolved
Hide resolved
dd-sdk-android-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/InstrumentationMode.kt
Outdated
Show resolved
Hide resolved
...-gradle-plugin/src/main/kotlin/com/datadog/gradle/plugin/kcp/InstrumentationConfiguration.kt
Outdated
Show resolved
Hide resolved
3f5add2 to
a3109d7
Compare
What does this PR do?
This PR implements the DSL config for auto instrumentation, so that clients can define the config like:
Motivation
RUM-8950
Review checklist (to be filled by reviewers)