Skip to content

Conversation

@ambushwork
Copy link
Member

@ambushwork ambushwork commented Mar 12, 2025

What does this PR do?

This PR implements the DSL config for auto instrumentation, so that clients can define the config like:

datadog{

      composeInstrumentation{
              trackViews =  InstrumentationMode.AUTO
              trackActions =  InstrumentationMode.ANNOTATION
              recordImages =  InstrumentationMode.DISABLE
      }
}

Motivation

RUM-8950

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork ambushwork force-pushed the yl/kcp/dsl-config branch 2 times, most recently from ad3f7ef to 7076fc0 Compare March 12, 2025 15:42
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 76.13636% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.17%. Comparing base (3e597fc) to head (a3109d7).
Report is 2 commits behind head on feature/kotlin-compiler-plugin.

Files with missing lines Patch % Lines
...atadog/gradle/plugin/kcp/DatadogPluginRegistrar.kt 50.00% 9 Missing and 1 partial ⚠️
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 0.00% 9 Missing ⚠️
.../datadog/gradle/plugin/DdExtensionConfiguration.kt 66.67% 1 Missing ⚠️
...n/com/datadog/gradle/plugin/InstrumentationMode.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##             feature/kotlin-compiler-plugin     #330      +/-   ##
====================================================================
- Coverage                             78.26%   78.17%   -0.09%     
- Complexity                              315      330      +15     
====================================================================
  Files                                    37       41       +4     
  Lines                                  1233     1315      +82     
  Branches                                149      154       +5     
====================================================================
+ Hits                                    965     1028      +63     
- Misses                                  187      205      +18     
- Partials                                 81       82       +1     
Files with missing lines Coverage Δ
...om/datadog/gradle/plugin/kcp/DatadogIrExtension.kt 66.67% <100.00%> (+30.95%) ⬆️
...DatadogKotlinCompilerPluginCommandLineProcessor.kt 100.00% <100.00%> (ø)
.../gradle/plugin/kcp/InstrumentationConfiguration.kt 100.00% <100.00%> (ø)
...gradle/plugin/kcp/InternalCompilerConfiguration.kt 100.00% <100.00%> (ø)
.../datadog/gradle/plugin/DdExtensionConfiguration.kt 92.86% <66.67%> (-3.14%) ⬇️
...n/com/datadog/gradle/plugin/InstrumentationMode.kt 75.00% <75.00%> (ø)
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 59.69% <0.00%> (-2.21%) ⬇️
...atadog/gradle/plugin/kcp/DatadogPluginRegistrar.kt 62.96% <50.00%> (-37.04%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork ambushwork marked this pull request as ready for review March 13, 2025 07:46
@ambushwork ambushwork requested review from a team as code owners March 13, 2025 07:46
@ambushwork ambushwork force-pushed the yl/kcp/dsl-config branch 2 times, most recently from fb19a29 to 6eda9f4 Compare March 13, 2025 09:42
@ambushwork ambushwork requested a review from 0xnm March 13, 2025 10:09
0xnm
0xnm previously approved these changes Mar 13, 2025
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I've left few suggestion, mainly to remove mention of "Kotlin Compiler" plugin from the public docs, because for the end-user it is just a single plugin (Gradle plugin) who does the job.

@ambushwork ambushwork merged commit 13ecbb5 into feature/kotlin-compiler-plugin Mar 13, 2025
13 checks passed
@ambushwork ambushwork deleted the yl/kcp/dsl-config branch March 13, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants