RUM-8910: Improve big mapping file handling in the shrinking process #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| shrinkedFile.bufferedWriter(bufferSize = MAPPING_OPTIMIZED_FILE_WRITE_BUFFER_SIZE) | ||
| .use { shrinkedFileWriter -> | ||
| mappingFile.useLines { lines -> | ||
| lines.run { if (mappingFileTrimIndents) map { it.trimStart() } else this } |
There was a problem hiding this comment.
⚪ Code Quality Violation
if/else statements should use braces. (...read more)
Comment on lines
+133
to
+135
| if (shrinkedFile.exists()) { | ||
| shrinkedFile.delete() | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Single line if statements should not use braces. (...read more)
| shrinkedFile.bufferedWriter(bufferSize = MAPPING_OPTIMIZED_FILE_WRITE_BUFFER_SIZE) | ||
| .use { shrinkedFileWriter -> | ||
| mappingFile.useLines { lines -> | ||
| lines.run { if (mappingFileTrimIndents) map { it.trimStart() } else this } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Braces are required for multiline if else statements. (...read more)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #326 +/- ##
=============================================
- Coverage 77.94% 77.88% -0.06%
- Complexity 258 260 +2
=============================================
Files 31 31
Lines 943 945 +2
Branches 113 113
=============================================
+ Hits 735 736 +1
Misses 151 151
- Partials 57 58 +1
🚀 New features to boost your workflow:
|
xgouchet
approved these changes
Mar 10, 2025
0xnm
deleted the
nogorodnikov/rum-8910/improve-big-file-handling-for-mapping-file-shrinking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mapping file can read few hundred MBs and so this PR improves its handling in such case by:
Review checklist (to be filled by reviewers)