Skip to content

Conversation

@0xnm
Copy link
Member

@0xnm 0xnm commented Mar 5, 2025

What does this PR do?

Small improvement for the mappingFilePackageAliases configuration usage: since keys are used in the regex, . can be interpreted as any symbol and users may also include .* as a wildcard.

This PR threatens the former as a literal instead of being meta sequence and ignores the latter (since keys are supposed to be the prefixes).

This should speed up algorithm a bit on the large files.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners March 5, 2025 14:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (ad67028) to head (79a175d).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #325      +/-   ##
=============================================
+ Coverage      77.79%   78.15%   +0.37%     
- Complexity       258      260       +2     
=============================================
  Files             31       31              
  Lines            941      943       +2     
  Branches         113      113              
=============================================
+ Hits             732      737       +5     
+ Misses           152      151       -1     
+ Partials          57       55       -2     
Files with missing lines Coverage Δ
...com/datadog/gradle/plugin/MappingFileUploadTask.kt 84.72% <100.00%> (+0.44%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm 0xnm merged commit 4041e2d into develop Mar 6, 2025
12 checks passed
@0xnm 0xnm deleted the nogorodnikov/rums-4053/espace-user-input-for-mapping-file-package-aliases branch March 6, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants