Skip to content

Conversation

@0xnm
Copy link
Member

@0xnm 0xnm commented Apr 11, 2024

What does this PR do?

This PR switches to the lazy configuration of upload task by using TaskContainer#register API instead of TaskContainer#create. This solves the problem of compatibility with https://github.com/Triple-T/gradle-play-publisher plugin which is similar to what described here Triple-T/gradle-play-publisher#940.

Long-term solution will be to switch from the legacy Variant API to the new Variant API.

Note: This is a partial fix, because if both tasks try to configure themselves in the same build execution, the problem will still occur. But it is not clear if it should be fixed on our side or problem is on the gradle-play-publisher plugin side.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 11, 2024 10:31
@0xnm 0xnm changed the base branch from develop to release/1.13.0 April 11, 2024 10:33
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

Merging #240 (2651409) into release/1.13.0 (85c7d67) will increase coverage by 0.57%.
The diff coverage is 83.33%.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.13.0     #240      +/-   ##
====================================================
+ Coverage             76.65%   77.22%   +0.57%     
  Complexity              201      201              
====================================================
  Files                    26       26              
  Lines                   788      790       +2     
  Branches                104      104              
====================================================
+ Hits                    604      610       +6     
+ Misses                  147      143       -4     
  Partials                 37       37              
Files Coverage Δ
...tlin/com/datadog/gradle/plugin/DdFileUploadTask.kt 80.65% <100.00%> (-0.66%) ⬇️
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 61.11% <80.77%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

@0xnm 0xnm marked this pull request as draft April 11, 2024 11:52
@0xnm 0xnm force-pushed the nogorodnikov/rum-4031/avoid-eager-fetching-of-variant-values branch from 8f578d5 to 8b2cb5f Compare April 11, 2024 12:47
@0xnm 0xnm marked this pull request as ready for review April 11, 2024 12:58
@0xnm 0xnm force-pushed the nogorodnikov/rum-4031/avoid-eager-fetching-of-variant-values branch from 8b2cb5f to 2651409 Compare April 11, 2024 13:00
@0xnm 0xnm merged commit ca500d5 into release/1.13.0 Apr 11, 2024
@0xnm 0xnm deleted the nogorodnikov/rum-4031/avoid-eager-fetching-of-variant-values branch April 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants