do not instantiate TestVisibility::Recorder unless CI visibility is enabled #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-fernandez
approved these changes
Dec 13, 2023
anmarchenko
deleted the
anmarchenko/do_not_start_recorder_when_ci_disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a NullRecorder subclass of TestVisibility::Recorder with an empty constructor and with all methods skipping tracing. When CI mode is not enabled, NullRecorder is being created to make Datadog::CI public interface work without errors.
Motivation
Recent case of TestVisibility::Recorder emitting logs in production when validating environment variables
How to test the change?
Unit tests are provided. Run a rails app with tracing enabled and check that there are no logs coming from CI module.