Skip tracing when CI mode disabled and manual API is used #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Couple of small but important fixes regarding CI mode configuration:
settings.ci.enabled
tofalse
(when running tests locally) leads to a complete failure because@ci_recorder
is nil. Now we are creating the recorder in disabled state in this case to stop tracing but preserving the behaviour.NullSpan
which is an implementation of NullObject pattern.How to test the change?
Unit tests are provided