Skip to content

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Disables 128-bit trace_id generation for CI mode. Tracing enabled it by default in DataDog/dd-trace-rb#3266

Motivation
128-bit trace ids cause message pack to fail with "Cause: bignum too big to convert into `unsigned long long'" causing agentless mode to fail completely

How to test the change?

git clone https://github.com/DataDog/test-environment

cd test-environment

yarn

cd dd-trace-rb/jekyll
bundle add ddtrace --git "https://github.com/DataDog/dd-trace-rb.git" --branch "master" --skip-install
bundle install --path .bundle
cd ../..

yarn test dd-trace-rb/jekyll.test.js

cd dd-trace-rb/devdocs
bundle add ddtrace --git "https://github.com/DataDog/dd-trace-rb.git" --branch "master" --skip-install
bundle install --path .bundle
cd ../..

yarn test dd-trace-rb/devdocs.test.js

@anmarchenko anmarchenko requested review from a team and ericlaz November 22, 2023 10:02
@anmarchenko anmarchenko merged commit 1d01489 into main Nov 22, 2023
@anmarchenko anmarchenko deleted the anmarchenko/disable_128bit_trace_ids branch November 22, 2023 10:09
@github-actions github-actions bot added this to the 0.5.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants