-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[OTAGENT-399] upgrade otel versions to v0.126.0 #36940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Go Package Import DifferencesBaseline: 4f20f80
|
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision❌ Failed Currently this PR is blocked, you can reach out to #agent-delivery-help to get support/ask for an exception. |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 4f20f80 Optimization Goals: ❌ Regression(s) detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
❌ | otlp_ingest_metrics | memory utilization | +7.62 | [+7.45, +7.78] | 1 | Logs |
➖ | ddot_metrics | memory utilization | +3.88 | [+3.77, +3.99] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +1.38 | [-1.39, +4.15] | 1 | Logs bounds checks dashboard |
➖ | docker_containers_memory | memory utilization | +0.96 | [+0.91, +1.01] | 1 | Logs |
➖ | file_tree | memory utilization | +0.70 | [+0.56, +0.85] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.56 | [+0.51, +0.61] | 1 | Logs |
➖ | docker_containers_cpu | % cpu utilization | +0.31 | [-3.44, +4.05] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.12 | [-0.56, +0.80] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.05 | [-0.19, +0.28] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.04 | [-0.60, +0.67] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.03 | [-0.61, +0.67] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.03 | [-0.63, +0.69] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.28, +0.30] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.02] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.00 | [-0.66, +0.67] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.64, +0.59] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.67, +0.62] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.95 | [-1.84, -0.07] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -1.76 | [-1.81, -1.71] | 1 | Logs bounds checks dashboard |
➖ | ddot_logs | memory utilization | -2.04 | [-2.16, -1.92] | 1 | Logs |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -2.12 | [-2.19, -2.06] | 1 | Logs |
➖ | otlp_ingest_logs | memory utilization | -2.67 | [-2.80, -2.55] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -4.31 | [-4.42, -4.20] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | docker_containers_cpu | simple_check_run | 10/10 | |
✅ | docker_containers_memory | memory_usage | 10/10 | |
✅ | docker_containers_memory | simple_check_run | 10/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
8a1e223
to
83dc291
Compare
cc @IbraheemA this should unblock #36532 |
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
upgrade otel versions to v0.126.0 + fix several breaking changes
Motivation
routine otel deps upgrade
Describe how you validated your changes
existing unit + e2e tests
Possible Drawbacks / Trade-offs
In this version otel upstream added trusted platform module (TPM) support to TLS package which pulls in many new transitive dependencies, thus a big delta in
Go Package Import Differences