NFC-V support

[TheKogoro]

Description of the feature you're suggesting.

Many NFC system using NVC-V keycard (ISO 15693) that isnt supported by flipper zero actually. NFC-V is main used by most of Skydata system (Parking lot, Ski station, and many other system...).

Actually, NFC-V is "readable" but cannot do nothing with it on flipper. It only showing a number without any possibility

Anything else?

No response

[nemanjan00]

That is due to limitation of NFC chipset used in flipper

[vikwin]

That is due to limitation of NFC chipset used in flipper

That's not true. It's just not implemented on official firmware yet. See this pull request, someone already implemented a working draft with further NFC-V / ISO 15693 features:
flipperdevices/flipperzero-firmware#1991

[nemanjan00]

As I said, lib and chip is not designed for anything other than reading of NFC-V...

Anything else is usage of chip outside of spec and hack

[nemanjan00]

I have to correct myself. Apparently, there is raw mode which can be used to interact with ISO15693 cards.

Thanks to @bettse for correcting me

[leofleischmann]

I would LOVE to see the support for NFC-V Tags as soon as possible (In the official firmware) :)

[FoxLy1312]

Awesome, thanks for your Work :D Make my day <3 Am 14. Jan. 2023, 11:06 +0100 schrieb Enteee ***@***.***>:

…

well, there is this: flipperdevices/flipperzero-firmware#1991 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[nemanjan00]

PR is not draft anymore. It is pending review now

Maybe time to merge?

flipperdevices/flipperzero-firmware#2316

[amec0e]

PR is not draft anymore. It is pending review now

Maybe time to merge?

flipperdevices/flipperzero-firmware#2316

Merging is blocked on that PR, until it is merged it is not ready.

[RogueMaster]

You can ask the developer @g3gg0, this has been ready for a bit

[amec0e]

Assuming OFW don't want to make any additional changes

[g3gg0]

In this case the code is not 100% clean as it still directly access rfal* functions from some other layer.
And there are for sure also some other quirks which are not that great.

Flipper zero crew are taking things serious.
They have set rules and seem to follow them, which is a good practice.
So not having merged the PR already is absolutely okay and I am fine with that.

The underlying PulseReader/DigitalSequence PR was said to get merged soon, so I think
I have reached the expected code quality for that part. And for the NfcV stuff I hope to get some
feedback, but I think this will take until their NFC API rework goes live.

Thats the "does it follow my architecture" point of view.

From a "stability" point of view however, I consider the NfcV stuff stable enough for a merge.
Haven't seen any crashes, hickups or nonfunc situations.
It was also successfully used by some other dev as underlying layer for picopass emulation.

So you can decide if it matches your criteria.

In any case, I would really love to see other people joining the work on it and e.g. file PRs to improve the NfcV code.
There was a question if I could add writing memory payload to another card, maybe add some other card types etc.
And also the rfal or generally adoption to the new NFC API are things, help would be appreciated :)

Regards,
g3gg0

[xMasterX]

You can ask the developer @g3gg0, this has been ready for a bit

We will wait for official team to review that changes
Or if author wants to send copy of that PR to our repo directly we can do our basic review (we have no dedicated nfc developers)
and merge it

[xMasterX]

In this case the code is not 100% clean as it still directly access rfal* functions from some other layer. And there are for sure also some other quirks which are not that great.

Flipper zero crew are taking things serious. They have set rules and seem to follow them, which is a good practice. So not having merged the PR already is absolutely okay and I am fine with that.

The underlying PulseReader/DigitalSequence PR was said to get merged soon, so I think I have reached the expected code quality for that part. And for the NfcV stuff I hope to get some feedback, but I think this will take until their NFC API rework goes live.

Thats the "does it follow my architecture" point of view.

From a "stability" point of view however, I consider the NfcV stuff stable enough for a merge. Haven't seen any crashes, hickups or nonfunc situations. It was also successfully used by some other dev as underlying layer for picopass emulation.

So you can decide if it matches your criteria.

In any case, I would really love to see other people joining the work on it and e.g. file PRs to improve the NfcV code. There was a question if I could add writing memory payload to another card, maybe add some other card types etc. And also the rfal or generally adoption to the new NFC API are things, help would be appreciated :)

Regards, g3gg0

Yes, you are right, but sometimes reviews from official team takes longer than expected
So if possible can you make a duplicate of that PR but to us direclty? if not possible do you agree if I merge it by committing it manually, but a bit later

[g3gg0]

Oh, thanks for that offer.
Right now I am working on so many topics, be it flipper related (flipperdevices/flipperzero-firmware#2311) or some other stuff (http://g3gg0.de) or even daily life, that I tend to get lost somewhere inbetween.
Opening another PR here would most likely cause a cerebral stack overflow.

I hope thats okay for you :)