Make PHP8.1 compatible with ArrayAccess interface #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannesvdvreken @finagin Any chance this could be merged? We're seeing these deprecation warnings a lot in our logs. |
Contributor
|
Sorry, this flew under our radar. We'll look at it ASAP. Thanks @hannesvdvreken for the tag! |
|
@tdtm Any timeline for a merge of this PR? |
mrdan
approved these changes
Jun 6, 2023
Member
|
Sorry for the delay, we've both a lot on our plates right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning with PHP8.1 a deprecation warning displays if the implemented method signatures do not match what is defined for the
ArrayAccessinterface. This can lead to excessive error log entries. Updated allowed PHP version in the composer.json to 8.1 to prevent PHP <8.1 from being impacted