This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Fix: Bump maxBuffer for Docker solc compilations #3139
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I found that 20MB should suffice (but 100 is probably on the safe side?). I'm not sure what negative implications a high number might have here |
Contributor
Author
|
@chmanie FWIW, apparently node 10 and lower's default I think 100 should be ok, but would be fine with 20 or 50. |
Contributor
|
👍 LGTM! |
coeniebeyers
added a commit
to Adhara-Tech/solidity-coverage
that referenced
this pull request
Aug 3, 2020
marsdalesa
pushed a commit
to Adhara-Tech/solidity-coverage
that referenced
this pull request
Apr 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3140.