feat: support `shanghai` hardfork #4272

davidmurdoch · 2023-03-02T00:08:18Z

EIP-3651: Warm COINBASE
- Needed to handle warming ourselves in simulateTransaction (eth_call). A new test was added for this.
EIP-3855: PUSH0 instruction
- No changes required
EIP-3860: Limit and meter initcode
- We've added a new option allowUnlimitedInitCodeSize to disable this EIP to continue to allow for uploading very large contracts. In most cases it will need to be combined with the allowUnlimitedContractSize option. Two new tests were added for this.
EIP-4895: Beacon chain push withdrawals as operations
- Needed to add new fields to Block: withdrawals and withdrawalsRoot.
EIP-6049: Deprecate SELFDESTRUCT
- No changes required. We could technically hook into the EVM steps and console.log a deprecation notice if the SELFDESTRUCT opcode is hit, but I feel like this sort of warning should happen at compilation, and not by a dev net client like Ganache. Also, maintaining the deprecation notice forever would suck. 🤔

This also fixes two bugs:

block size was not computed correctly (persisted databases will be updated and migrated automatically)
- the database migration may add a one-time delay to startup when using a persistent database (--database.dbPath). This should be insignificant for the majority of cases. The migration was benchmarked with 180000 blocks, and completed in 6.4 seconds.
internal "intrinsic gas" checks now correctly include accessList fees, if there are any.

cloudflare-workers-and-pages · 2023-03-14T15:57:01Z

Deploying with Cloudflare Pages

Latest commit:	`7ffc5c3`
Status:	✅ Deploy successful!
Preview URL:	https://cb5ba1b5.ganache.pages.dev
Branch Preview URL:	https://update-ethereumjs.ganache.pages.dev

View logs

davidmurdoch · 2023-03-17T00:57:16Z

Note: CI failed due to time outs several times. I'm concerned that this PR introduces a performance regression and need to test Test timings in a more controlled manner (locally) before merging.

Co-authored-by: jeffsmale90 <[email protected]>

src/chains/ethereum/ethereum/src/blockchain.ts

Co-authored-by: jeffsmale90 <[email protected]>

…nto update-ethereumjs

src/chains/ethereum/ethereum/src/blockchain.ts

jeffsmale90 · 2023-04-12T03:50:07Z

src/chains/ethereum/ethereum/tests/api/eth/contracts/EthCall.sol

+    function getCoinbase() public view virtual returns (uint256) {
+        uint256 balance = address(block.coinbase).balance;
+        require(balance != 0, "coinbase balance is not zero");
+        return gasleft();


accessCoinBase might be better, but it doesn't hint at what the return value is 🤷

src/chains/ethereum/ethereum/tests/database.test.ts

jeffsmale90 · 2023-04-12T04:18:21Z

src/chains/ethereum/ethereum/tests/forking/forking.test.ts

+      // this test uses the `network: "goerli"` option, which requires an
+      // infura key; when run our tests it must be provided as an environment
+      // variable.
+      if (!process.env.INFURA_KEY) this.skip();


Are we able to check if we are in CI and fail if the INFURA_KEY is not set?

Yes, github sets an env var we could check. This is a pattern we copied from elsewhere to skip tests that a run without providing an Infura key.

Sounds like a good future improvement :)

jeffsmale90 · 2023-04-12T04:19:16Z

src/chains/ethereum/ethereum/tests/provider.test.ts

    }).timeout(10000);
+
+    it("allows unlimited init code in transaction when the allowUnlimitedInitCodeSize option is set", async () => {
+      const largeInitCode = "0x" + "00".repeat(49153); // larger than init code allowance


Data.toString(0, 49153) would do the same 🤷

Seems like a reasonable change to me! I think this test was a copy+paste of a similar test that predates Data.toString , so I just didn't bother to change the format.

…' and 'allowUnlimitedContractSize'

davidmurdoch added 11 commits March 1, 2023 19:05

update ethereumjs packages

cc16b36

add common

777de6d

unbundle uws

f1f07b5

add shanghai as a hardfork option

0fc22aa

handle EIP 3651 in tx simulations

4cb850f

add test for eth_call coinbase read cost post shanghai

1d9f8b6

no .only

604ad42

hm

a00550d

idunno

44bcd14

neat

afe84dc

.

5159a30

davidmurdoch marked this pull request as ready for review March 8, 2023 16:17

Merge branch 'develop' into update-ethereumjs

26fa632

davidmurdoch requested a review from jeffsmale90 March 8, 2023 16:18

davidmurdoch added 2 commits March 8, 2023 17:10

Add INITCODE_TOO_LARGE message, limits, and tests

a6944fb

add allowUnlimitedInitCodeSize option

668661d

davidmurdoch added 3 commits March 14, 2023 14:05

progress

19eed03

add test

07e73b3

type

e83e4d0

davidmurdoch changed the title ~~feat: support shanghai hardfork~~ feat: support shanghai hardfork Mar 15, 2023

davidmurdoch added 4 commits March 15, 2023 17:43

Merge branch 'develop' into update-ethereumjs

49c9819

don't mutate it

9e79827

gotta stop mutating things that arne't mind to mutate

aae62bf

refactor

d8104fe

davidmurdoch added 4 commits March 17, 2023 13:37

a better workaround

375703a

remove timeouts

af1cb0a

workaround an EVM event.memory size issue

c3ff563

fix

1f6c2dd

remove redundant code

4962f97

davidmurdoch force-pushed the update-ethereumjs branch from f49ef2f to 4962f97 Compare April 11, 2023 14:41

davidmurdoch and others added 2 commits April 11, 2023 10:43

Update src/chains/ethereum/block/src/runtime-block.ts

a44a019

Update src/chains/ethereum/block/src/runtime-block.ts

b2e1508

Co-authored-by: jeffsmale90 <[email protected]>

davidmurdoch commented Apr 11, 2023

View reviewed changes

src/chains/ethereum/ethereum/src/blockchain.ts Outdated Show resolved Hide resolved

davidmurdoch and others added 8 commits April 11, 2023 10:49

Update src/chains/ethereum/ethereum/src/blockchain.ts

0e70196

Update src/chains/ethereum/ethereum/src/data-managers/block-manager.ts

f0e9d9f

Co-authored-by: jeffsmale90 <[email protected]>

Update src/chains/ethereum/ethereum/src/helpers/common-helpers.ts

f65bd90

Co-authored-by: jeffsmale90 <[email protected]>

clarify behavior in comments and function names

95724c5

Merge branch 'update-ethereumjs' of github.com:trufflesuite/ganache i…

c8dc6c6

…nto update-ethereumjs

use Address type

766b99b

rename function

19edfd9

update comment, remove redundant code

7736988

davidmurdoch commented Apr 11, 2023

View reviewed changes

src/chains/ethereum/ethereum/src/blockchain.ts Outdated Show resolved Hide resolved

davidmurdoch added 8 commits April 11, 2023 11:57

comment

f6ce54c

change default hardfork to shanghai

4756983

update tests due to account balance changes

c35559c

update error message in test to reflect shanghai

5ba981c

update subscription to include withdrawalsRoot

a166f1d

update hash-related values to shanghai

547c11d

just use empty merkle root

fda51fd

fix test?

82f723b

jeffsmale90 reviewed Apr 12, 2023

View reviewed changes

Tidy up some tests, change description of 'allowUnlimitedInitCodeSize…

7ffc5c3

…' and 'allowUnlimitedContractSize'

jeffsmale90 approved these changes Apr 12, 2023

View reviewed changes

jeffsmale90 merged commit 4ae38db into develop Apr 12, 2023

jeffsmale90 deleted the update-ethereumjs branch April 12, 2023 22:38

mikeseese mentioned this pull request Apr 12, 2023

Mine a block exactly at the given timestamp #13

Merged

Woodpile37 mentioned this pull request Jun 19, 2023

[Snyk] Upgrade @ganache/flavors from 0.3.0 to 0.9.0 Woodpile37/ganache#76

Open

X-oss-byte mentioned this pull request Jul 15, 2023

[Snyk] Upgrade @ganache/utils from 0.3.0 to 0.8.0 X-oss-byte/ganache#19

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support `shanghai` hardfork #4272

feat: support `shanghai` hardfork #4272

Uh oh!

davidmurdoch commented Mar 2, 2023 •

edited by jeffsmale90

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Mar 14, 2023 •

edited

Loading

Uh oh!

davidmurdoch commented Mar 17, 2023

Uh oh!

Uh oh!

Uh oh!

jeffsmale90 Apr 12, 2023

Uh oh!

Uh oh!

jeffsmale90 Apr 12, 2023

Uh oh!

davidmurdoch Apr 12, 2023 •

edited

Loading

Uh oh!

jeffsmale90 Apr 12, 2023

Uh oh!

jeffsmale90 Apr 12, 2023

Uh oh!

davidmurdoch Apr 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: support shanghai hardfork #4272

feat: support shanghai hardfork #4272

Uh oh!

Conversation

davidmurdoch commented Mar 2, 2023 • edited by jeffsmale90 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

davidmurdoch commented Mar 17, 2023

Uh oh!

Uh oh!

Uh oh!

jeffsmale90 Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jeffsmale90 Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

davidmurdoch Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeffsmale90 Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

jeffsmale90 Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

davidmurdoch Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: support `shanghai` hardfork #4272

feat: support `shanghai` hardfork #4272

davidmurdoch commented Mar 2, 2023 •

edited by jeffsmale90

Loading

cloudflare-workers-and-pages bot commented Mar 14, 2023 •

edited

Loading

davidmurdoch Apr 12, 2023 •

edited

Loading