This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: evm_revert fails in some cases
#4136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
changed the title
evm_revert fails in some cases
MicaiahReid
suggested changes
Jan 9, 2023
Contributor
MicaiahReid
left a comment
MicaiahReid
left a comment
There was a problem hiding this comment.
Took me a bit, but I think the actual test changes make sense and look good for me. Just some small nits and I'll be ready to approve.
davidmurdoch
reviewed
Jan 9, 2023
davidmurdoch
approved these changes
Jan 9, 2023
MicaiahReid
approved these changes
Jan 9, 2023
Co-authored-by: Micaiah Reid <[email protected]> Co-authored-by: David Murdoch <[email protected]>
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Ganache Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where
evm_revertwould fail with error.for is not iterable. This happened when a user would attempt to revert a change that deletes a key that exists in an upstream network.fixes: #4093