This repository was archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 682
docs: restyle docs to be more "Truffley" #4035
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Murdoch <[email protected]>
Co-authored-by: David Murdoch <[email protected]>
Contributor
|
This looks great! |
jeffsmale90
reviewed
Dec 15, 2022
| transform: translate(-3vw, calc(-100% + 3.05vw)); | ||
| padding: 0.5vw 1vw 3vw; | ||
| text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.5); | ||
| /* text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.5); */ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probs delete this I guess?
Suggested change
| /* text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.5); */ |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally. I just commented this out initially because I was unsure if it aided readability in dark mode (I was primarily working in light mode at the time).
| .hljs { | ||
| font-family: "Share Tech Mono", monospace; | ||
| text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.7); | ||
| /* text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.7); */ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| /* text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.7); */ |
Contributor
Author
|
UPDATE: They were caused by the padding. Outstanding issues:
I think these are both caused by the padding I added to |
764a928 to
cf8fe21
Compare
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought the styling of the docs closer to Truffle Dashboard, including fun things like a color changing theme switcher icon! Contrast is greater in the console elements in light mode as well. Other minor changes too numerous to list.