This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: make debug_storageRangeAt return all known keys at transaction index
#3470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
changed the title
debug_storageRangeAtdebug_storageRangeAt return all know keys at transaction index
davidmurdoch
changed the title
debug_storageRangeAt return all know keys at transaction indexdebug_storageRangeAt return all known keys at transaction index
davidmurdoch
commented
Aug 3, 2022
src/chains/ethereum/ethereum/tests/api/debug/debug_storageRangeAt.test.ts
Show resolved
Hide resolved
src/chains/ethereum/ethereum/tests/api/debug/debug_storageRangeAt.test.ts
Show resolved
Hide resolved
src/chains/ethereum/ethereum/tests/api/debug/debug_storageRangeAt.test.ts
Show resolved
Hide resolved
davidmurdoch
requested review from
MicaiahReid,
jeffsmale90 and
tenthirtyone
and removed request for
MicaiahReid and
jeffsmale90
tenthirtyone
reviewed
Aug 5, 2022
MicaiahReid
previously requested changes
Aug 10, 2022
src/chains/ethereum/ethereum/tests/api/debug/debug_storageRangeAt.test.ts
Show resolved
Hide resolved
src/chains/ethereum/ethereum/tests/api/debug/debug_storageRangeAt.test.ts
Show resolved
Hide resolved
jeffsmale90
suggested changes
Aug 16, 2022
jeffsmale90
approved these changes
Aug 23, 2022
Contributor
tenthirtyone
left a comment
tenthirtyone
left a comment
There was a problem hiding this comment.
Just comments no changes requested
src/chains/ethereum/ethereum/tests/api/debug/debug_storageRangeAt.test.ts
Show resolved
Hide resolved
davidmurdoch
force-pushed
the
fix-storageRange
branch
from
79b7e67 to
ae9bcf3
Compare
davidmurdoch
dismissed
MicaiahReid’s stale review
Because github says there are unresolved comments but also says there are no unresolved comments.
MicaiahReid
reviewed
Jan 10, 2023
MicaiahReid
reviewed
Jan 10, 2023
MicaiahReid
reviewed
Jan 10, 2023
MicaiahReid
approved these changes
Jan 10, 2023
jeffsmale90
approved these changes
Feb 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug_storageRangeAtwould sometimes fail to find storage that was there at the start of the transaction if the storage slots were written to in the same block as the target transaction. Ganache now waits to read storage slots until after the requisite transactions in the block have been processed.Fixes #3338, also fixes #3468