Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Fix mb_stripos offset parameter for php 8.1 #98

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

jakubvojacek
Copy link
Contributor

without this the method throws deprecation warning

mb_stripos(): Passing null to parameter #3 ($offset) of type int is deprecated

@Naktibalda
Copy link
Member

Thanks, could you make another pull request and update https://github.com/Codeception/Codeception/blob/5.0/src/PHPUnit/Constraint/Page.php too ?

@Naktibalda
Copy link
Member

I fixed CI in 9.0 branch, please update your branch.

@jakubvojacek
Copy link
Contributor Author

Hello

I checked https://github.com/Codeception/Codeception/blob/5.0/src/PHPUnit/Constraint/Page.php and mb_stripos seems to already have correct parameter (0 instead of null)

@jakubvojacek
Copy link
Contributor Author

Branch updated, I hope

@Naktibalda Naktibalda merged commit 7d6b1a5 into Codeception:9.0 Jan 26, 2022
@jakubvojacek
Copy link
Contributor Author

Any idea as to when this could be tagged? :)

@Naktibalda
Copy link
Member

Released as 9.0.7

@jakubvojacek
Copy link
Contributor Author

Thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants