This repository was archived by the owner on Mar 12, 2025. It is now read-only.
Register the SymfonyTestListener with the correct state #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @DavertMik @Naktibalda |
Naktibalda
reviewed
Sep 7, 2018
There was a problem hiding this comment.
If you say that it solves an issue, then it probably does.
I see nothing wrong with this change, but I will leave it for @DavertMik to merge.
|
Yeah, let's hope it fixes something and doesn't break anything. |
|
@DavertMik @Naktibalda is it possible to have a new v6 release with this fix included? Thanks! |
|
done. |
Naktibalda
pushed a commit
that referenced
this pull request
Sep 28, 2018
|
6.0.12 and 7.3.1 |
|
Thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't register the symfony listener as a global listener. So we should make sure we disable the global state.
Without this fix the
@expectedDeprecation(andClockMock,DnsMock, etc) won't work because the internal state of the listener is "-2" aka global listener. With this fix the listener gets the correct state of "0", the same as you would get when registering the listener within thephpunit.xmlconfig.