This repository was archived by the owner on Mar 12, 2025. It is now read-only.
Track all event objects for a suite in JSON logger (7.0) #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mycarrysun
changed the title
mycarrysun
commented
Jun 16, 2018
| * @param string $buffer | ||
| * @param array $event_data | ||
| */ | ||
| protected function addLogEvent($event_data = []): void |
There was a problem hiding this comment.
Used a class prop to store all events so we can write all the events properly JSON encoded at the end of the suite
This was referenced Jun 16, 2018
|
Got it, thanks! |
|
Btw, where do you use JSON reports? |
|
@DavertMik to save the output to our database - very helpful for logging and looking at the event objects to see what passed etc...but before the PR the json_decode function returned null. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33 and #5203