Skip to content

Remove outdated Symfony 3 logic #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TavoNiievez merged 1 commit into from
Dec 11, 2020
Merged

Remove outdated Symfony 3 logic #74

TavoNiievez merged 1 commit into from
Dec 11, 2020

Conversation

@TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented Dec 10, 2020

This logic is not necessary since this module no longer supports Symfony versions lower than 3.4

The ->getValue() method always exists and therefore it is safe to remove these internal functions.

@TavoNiievez TavoNiievez added this to the 1.5.0 milestone Dec 10, 2020
@TavoNiievez TavoNiievez merged commit 3dd2283 into Codeception:master Dec 11, 2020
@TavoNiievez TavoNiievez deleted the sf3_outdated_logic branch December 11, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naktibalda Naktibalda Naktibalda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@TavoNiievez @Naktibalda