Skip to content

Missing tests #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
71 of 75 tasks
TavoNiievez opened this issue Nov 23, 2020 · 1 comment · Fixed by #63
Closed
71 of 75 tasks

Missing tests #54

TavoNiievez opened this issue Nov 23, 2020 · 1 comment · Fixed by #63
Milestone
1.5.0

Comments

@TavoNiievez
Copy link
Member

TavoNiievez commented Nov 23, 2020 •
edited
Loading

Good. Once it is merged we should have corresponding tests in symfony-demo
Originally posted by @DavertMik in #50 (comment)

Due to the current test coverage of the module and the time it would take to correct compatibility issues in current test projects, I decided to create a new test project with 3 branches:

  • main, for the latest version of Symfony (5.2)
  • 4.4, for the latest LTS and,
  • 3.4 for the oldest LTS.
Click to see progress on Symfony 5.2
  • amLoggedInAs
  • amOnAction
  • amOnRoute
  • dontSeeAuthentication
  • dontSeeEmailIsSent
  • dontSeeFormErrors
  • grabParameter
  • grabRepository
  • grabService
  • logout
  • runSymfonyConsoleCommand
  • seeAuthentication
  • seeCurrentActionIs
  • seeCurrentRouteIs
  • seeEmailIsSent
  • seeFormErrorMessage
  • seeFormHasErrors
  • seeInCurrentRoute
  • seeInSession
  • seeNumRecords
  • seePageIsAvailable
  • seePageRedirectsTo
  • seeUserHasRole
  • seeUserPasswordDoesNotNeedRehash
  • submitSymfonyForm
Click to see progress on Symfony 4.4
  • amLoggedInAs
  • amOnAction
  • amOnRoute
  • dontSeeAuthentication
  • dontSeeEmailIsSent
  • dontSeeFormErrors
  • grabParameter
  • grabRepository
  • grabService
  • logout
  • runSymfonyConsoleCommand
  • seeAuthentication
  • seeCurrentActionIs
  • seeCurrentRouteIs
  • seeEmailIsSent
  • seeFormErrorMessage
  • seeFormHasErrors
  • seeInCurrentRoute
  • seeInSession
  • seeNumRecords
  • seePageIsAvailable
  • seePageRedirectsTo
  • seeUserHasRole
  • seeUserPasswordDoesNotNeedRehash
  • submitSymfonyForm
Click to see progress on Symfony 3.4
  • amLoggedInAs
  • amOnAction
  • amOnRoute
  • dontSeeAuthentication
  • dontSeeEmailIsSent
  • dontSeeFormErrors
  • grabParameter
  • grabRepository
  • grabService
  • logout
  • runSymfonyConsoleCommand
  • seeAuthentication
  • seeCurrentActionIs
  • seeCurrentRouteIs
  • seeEmailIsSent
  • seeFormErrorMessage
  • seeFormHasErrors
  • seeInCurrentRoute
  • seeInSession
  • seeNumRecords
  • seePageIsAvailable
  • seePageRedirectsTo
  • seeUserHasRole
  • seeUserPasswordDoesNotNeedRehash
  • submitSymfonyForm

This new test project serves as a replacement for:
[Naktibalda/codeception-symfony-tests] [Codeception/symfony-demo].
@TavoNiievez TavoNiievez added the help wanted Extra attention is needed label Nov 23, 2020
@TavoNiievez TavoNiievez added this to the 1.5.0 milestone Nov 24, 2020
@TavoNiievez TavoNiievez mentioned this issue Nov 26, 2020
Closed
@TavoNiievez
Copy link
Member Author

TavoNiievez commented Nov 27, 2020 •
edited
Loading

I feel quite comfortable with the current test coverage. Some Symfony 3.4 methods require extra attention like SwiftMailer email, but anyone who does actively use that version of symfony can contribute them. So, for my part this is ready to go.

@TavoNiievez TavoNiievez mentioned this issue Nov 27, 2020
Merged
@TavoNiievez TavoNiievez removed the help wanted Extra attention is needed label Nov 27, 2020
@TavoNiievez TavoNiievez mentioned this issue Dec 9, 2020
Merged
ThomasLandauer added a commit to ThomasLandauer/module-symfony that referenced this issue Apr 4, 2021
@ThomasLandauer
Fixing submitSymfonyForm()
6804410 
I'm not sure about this!
But I think the submitted fieldname now is `myFormaddress`, instead of `myForm[address]` - that's what I'm trying to fix.
I didn't take a look at the tests you mentioned in Codeception#54
@ThomasLandauer ThomasLandauer mentioned this issue Apr 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Updated Test Project
1 participant
@TavoNiievez