-
Notifications
You must be signed in to change notification settings - Fork 25
Status of Swift Mailer support in v2.0.0? #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ThomasLandauer As always, thanks for opening. You're right. I updated the release notes to include that explanation. Is it okay as it is?
Yes, you're right, it seems like something important. The idea is that if you use Swift Mailer and you don't want (or can't) update to Symfony Mailer just stay on the 1.x branch of this module, please send a PR... the message you mention is fine for me. |
Yes, they are Codeception version numbers, and the buttons are generated by documentation page generator, so they are the same for all modules. Codeception had links to older versions of documentation probably since 2.0 release (If I remember correctly, they were to 1.6 and 1.8 versions originaly), so I replaced them with links to last minor versions when I extracted modules to separate repositories. I don't know if they ever were useful to anyone, but I think that they can be removed now. |
Release notes: Since nobody knows about
|
@ThomasLandauer Done. |
@TavoNiievez Am I right that the
mailer
configuration you/we introduced in https://github.com/Codeception/module-symfony/pull/9/files was removed in v2.0.0, and the module just doesn't work with Swift Mailer anymore?At https://github.com/Codeception/module-symfony/releases/tag/2.0.0 you only mentioned that Symfony 4.4 is required, but this doesn't automatically mean that Swift Mailer was dropped in favor of Symfony Mailer, cause Swift Mailer is still supported in Symfony 4.4: https://symfony.com/doc/4.4/email.html
This is the "Fail" message people get when running their tests:
And I'd say it should be reworded into something like:
... cause some people might not have heard of Symfony Mailer at all yet ;-)
But it would be better to inform people upfront that it's not going to work. How could we do that? Maybe a yellow box at https://codeception.com/docs/modules/Symfony somewhere near the top? I can come up with some PR, but want to hear your opinion first :-)
BTW: On that page, what is that blue "table" in the top right: Changelog | Source | 3.1 | 2.5 | 1.8 ? The version numbers look like Codeception's, so they're quite misleading here. Do you know how/where this can be changed?
The text was updated successfully, but these errors were encountered: