Adjusts parser for "show ap cdp neighbor"

[jamiereid]

Description

Resolves #723

Adjust regex to include the ap neighbor IP as it is output on 9800 platform v17.x

Motivation and Context

The parser fails as it's not able to match when the ap cdp neighbor IP is in the same line as the other information.

[ThomasJRyan]

Thank you for your contribution.

A few things

1. Please include a unittest for this change. You can find existing unittests for this parser here

2. While I won't hold it against you, since you're updating this parser anyways I would appreciate if you could update line 1152 from Optional("neighbor_ip_addresses"): list to Optional("neighbor_ip_addresses"): ListOf(str) as it's a bit out of date for what we expect from a parser these days

[jamiereid]

Thank you @ThomasJRyan, and apologies for the delay in response. I have pushed some additional commits that (hopefully correctly) addresses your feedback. Please let me know :)

[ThomasJRyan]

Looks like your changes are causing existing unittests to fail.

This will need to be fixed up before we can merge. You can run the unittests locally by going into the tests folder and running the folder_parsing_job.py file

[jamiereid]

Apologies for the delay in replying. I fully intend to get this fixed up so it can be merged. Thank you for the tip on how to run the tests locally!, I hadn't spend enough time to figure that out yet.

[jamiereid]

I've looked into these most recent failures a little more but it's not clear to me the fix.

When I run the tests "directly" by changing into the tests directory and executing python folder_parsing_job.py they complete and all pass. Digging further into the way github is setup to run the tests though, I see it runs them through pyats pyats run job folder_parsing_job.py --no-mail --no-archive. This is failing locally for me as well, with the same VersionConflict error as github.

pkg_resources.VersionConflict: (genie.libs.parser 25.5 (/home/runner/work/genieparser/genieparser/src), Requirement.parse('genie.libs.parser<25.7.0,>=25.6.0'))

Are you able to advise, @ThomasJRyan?

[Taarini]

Your branch is not up to date with main. Please merge with the latest.

[jamiereid]

rebased on top of main (dc5e9db).

created a clean venv using python 3.12.6
pip installed pyats[full]
ran make develop

pyats run job folder_parsing_job.py --no-mail --no-archive still fails with

pkg_resources.VersionConflict: (genie.libs.parser 25.8 (/home/user/src/genieparser/src), Requirement.parse('genie.libs.parser<25.6.0,>=25.5.0'))

cd into tests, running python folder_parsing_job.py all tests pass.