Skip to content

Conversation

@matt-o-how
Copy link
Contributor

No description provided.

@matt-o-how matt-o-how requested a review from arvidn November 3, 2025 17:36
@matt-o-how matt-o-how marked this pull request as ready for review November 3, 2025 17:36
@coveralls-official
Copy link

coveralls-official bot commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19076152376

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 32 of 33 (96.97%) changed or added relevant lines in 4 files are covered.
  • 44 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 84.628%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/validation_error.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
crates/chia-consensus/src/spendbundle_validation.rs 1 99.62%
wheel/src/api.rs 43 84.84%
Totals Coverage Status
Change from base Build 19035434649: 0.02%
Covered Lines: 16995
Relevant Lines: 20082

💛 - Coveralls

@arvidn arvidn changed the title Add flag and check generator begins with quote [CHIA-3792] Add flag and check generator begins with quote Nov 4, 2025
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that all places check_generator_quote() is called from, we parse the program just a few lines below. I think it would be slightly more robust to check the parsed program. Granted, it wouldn't be as efficient in the failing case. However, that should be extremely rare.

@matt-o-how matt-o-how merged commit 46094fc into main Nov 5, 2025
81 checks passed
@matt-o-how matt-o-how deleted the disable_complex_generators branch November 5, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants