-
Notifications
You must be signed in to change notification settings - Fork 34
[CHIA-3792] Add flag and check generator begins with quote #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 19076152376Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
arvidn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that all places check_generator_quote() is called from, we parse the program just a few lines below. I think it would be slightly more robust to check the parsed program. Granted, it wouldn't be as efficient in the failing case. However, that should be extremely rare.
No description provided.