Fix potential security flaw in creation of sockets/directories #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setegid(st.st_gid); | ||
| seteuid(st.st_uid); | ||
| setegid(req_uid); | ||
| seteuid(req_uid); |
There was a problem hiding this comment.
This bit isn't really necessary, as req_uid == st.st_uid == st.st_gid. I should really just remove req_uid as it's not needed.
There was a problem hiding this comment.
Done. Have to rebase the patchset though
|
I'll test this when I get home. If we could discuss some more things over gtalk, I'd really appreciate it, I could use some help with a couple of things. |
|
Works in my testing, will send a couple builds out to my testers to see how it works for them before merging it. Doesn't seem to affect too much, so I don't see there being any issues. |
supplementary groups have been dropped already at this time (introduced by commit 00f1bb5)
Previous code created a file object with two steps: the creation itself with default umask/mode and setting necessary permissions then. This approach is known to lead to a race condition when malicious process can open an object before permissions is set. The patch sets creation mask (mask) to 027, thus denying any access from others. Also, the patch removes all dead code which is not needed after changes mentioned.
ChainsDD
added a commit
that referenced
this pull request
Dec 15, 2011
Fix potential security flaw in creation of sockets/directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit 8dc2877f8dbdf4161c394c28e714ee3efd645cf5
Well, I fixed last bit I didn't like in su-binary as promised. There is more stuff to fix:
(requires change in corresponding macro only)
Thus, su-binary won't touch flash, /dev is tmpfs nowadays
su-binary acess db only once, so db open/close can be moved to database_check
The socket is created once per su invocation. We can use pid in the socket name.
It's neither "safer" nor "weaker"
If you'll agree to accept mentioned changes I could prepare the patches.