Feat/217 add new registries #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
reviewed
Jun 23, 2025
| @@ -34,4 +35,5 @@ export const STATES = [ | |||
| WikiState, | |||
| MeetingsState, | |||
| RegistrationsState, | |||
| RegistriesState, | |||
There was a problem hiding this comment.
Remove it from here and use it in registries routes
|
|
||
| @Component({ | ||
| selector: 'osf-registries', | ||
| imports: [RouterModule], |
There was a problem hiding this comment.
Use RouterOutlet instead of RouterModule.
| @@ -0,0 +1,11 @@ | |||
| import { Provider } from '../models'; | |||
| import { ProvidersResponseJsonApi } from '../models/providers-json-api.model'; | |||
| @@ -0,0 +1,11 @@ | |||
| import { Project } from '../models'; | |||
| import { ProjectsResponseJsonApi } from '../models/projects-json-api.model'; | |||
…to feat/217-add-new-registries
…to feat/217-add-new-registries
…to feat/217-add-new-registries
…to feat/217-add-new-registries
…nScience/angular-osf into feat/217-add-new-registries
…to feat/217-add-new-registries
…to feat/217-add-new-registries
…to feat/217-add-new-registries
…nScience/angular-osf into feat/217-add-new-registries
…to feat/217-add-new-registries
…to feat/217-add-new-registries
nsemets
reviewed
Jul 1, 2025
There was a problem hiding this comment.
Add also here subject-service.model export.
| patchState({ | ||
| providers: { | ||
| data: providers, | ||
|
|
|
|
||
| export class PageSchemaMapper { | ||
| static fromSchemaBlocksResponse(response: SchemaBlocksResponseJsonApi): PageSchema[] { | ||
| console.log('PageSchemaMapper.fromSchemaBlocksResponse', response); |
|
|
||
| export const defaultSteps: StepOption[] = [ | ||
| { | ||
| label: 'Metadata', |
| projectId: this.fromProject ? (project ?? undefined) : undefined, | ||
| }) | ||
| .subscribe(() => { | ||
| this.toastService.showSuccess('Draft created successfully'); |
Comment on lines
+112
to
+119
| <h3 class="mb-2">Upload File</h3> | ||
| <p class="mb-1">You may attach up to 5 file(s) to this question. Files cannot total over 5GB in size.</p> | ||
| <p> | ||
| Uploaded files will automatically be archived in this registration. They will also be added to a related | ||
| project that will be created for this registration. | ||
| </p> | ||
|
|
||
| <p>File input is not implemented yet.</p> |
Comment on lines
49
to
51
| this.route.params.subscribe((params) => { | ||
| this.step.set(+params['step'].split('-')[0]); | ||
| }); |
There was a problem hiding this comment.
Try to use toSignal. I think you can add it instead of step = signal(this.route.snapshot.params['step'].split('-')[0]);.
There was a problem hiding this comment.
As you can see step is already signal, but without subscription, it doesn't reflect on the params changes
| } | ||
|
|
||
| stepChange(step: number): void { | ||
| // TODO: before navigating, validate the current step |
There was a problem hiding this comment.
Remove it or add correct format: [NM] TODO: ....
| } | ||
|
|
||
| onFocusOut() { | ||
| // TODO: make request to update contributor if changed |
There was a problem hiding this comment.
Make it right format [NM] TODO: .
There was a problem hiding this comment.
Rename component files to registries-subjects
nsemets
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.