-
Notifications
You must be signed in to change notification settings - Fork 82
Better support for ECDSA signatures in ABI arguments #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
14d614b to
f9f5958
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 97.35% 97.42% +0.07%
==========================================
Files 76 78 +2
Lines 17440 17970 +530
Branches 1274 1349 +75
==========================================
+ Hits 16978 17508 +530
- Misses 455 456 +1
+ Partials 7 6 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f9f5958 to
252ec71
Compare
|
Had a rare case where an ECDSA signature was 70 bytes long. included in most recent commit |
2648ec8 to
0ebac8c
Compare
|
Thanks again for the contribution @mainnet-pat! We've made some small changes to the tests, and will now merge this PR. It will be included in v0.12. |
Co-authored-by: Rosco Kalis <[email protected]>
Do not fail to accept ECDSA tx signatures and data signatures