Skip to content

Conversation

@mainnet-pat
Copy link
Contributor

@mainnet-pat mainnet-pat commented Jun 26, 2025

Do not fail to accept ECDSA tx signatures and data signatures

@vercel
Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cashscript Ready Ready Preview Comment Sep 23, 2025 8:57am

@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.42%. Comparing base (47a9dbc) to head (0ebac8c).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   97.35%   97.42%   +0.07%     
==========================================
  Files          76       78       +2     
  Lines       17440    17970     +530     
  Branches     1274     1349      +75     
==========================================
+ Hits        16978    17508     +530     
- Misses        455      456       +1     
+ Partials        7        6       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mainnet-pat
Copy link
Contributor Author

Had a rare case where an ECDSA signature was 70 bytes long. included in most recent commit

@mr-zwets mr-zwets linked an issue Sep 11, 2025 that may be closed by this pull request
@rkalis
Copy link
Member

rkalis commented Sep 23, 2025

Thanks again for the contribution @mainnet-pat!

We've made some small changes to the tests, and will now merge this PR. It will be included in v0.12.

@rkalis rkalis merged commit d349ebf into CashScript:v0.12-release Sep 23, 2025
2 of 3 checks passed
rkalis added a commit that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proper support for ECDSA sigs as contract unlocker arguments

2 participants