Skip to content

Conversation

@Brooooooklyn
Copy link
Owner

No description provided.

@Brooooooklyn Brooooooklyn marked this pull request as ready for review December 17, 2025 06:28
Copilot AI review requested due to automatic review settings December 17, 2025 06:28
@Brooooooklyn Brooooooklyn merged commit e17c4e5 into main Dec 17, 2025
50 checks passed
@Brooooooklyn Brooooooklyn deleted the release branch December 17, 2025 06:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Windows ARM64 platform (aarch64-pc-windows-msvc) to the canvas project. The changes enable building, testing, and distributing native binaries for Windows on ARM64 devices.

Key changes:

  • Added Windows ARM64 target configuration to build scripts and package.json
  • Created platform-specific npm package for win32-arm64-msvc
  • Updated CI/CD workflows to build and test on Windows ARM64 runners
  • Modified pathkit tests to skip flaky tests on Windows ARM64 platform

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/utils.mjs Added library path mapping for aarch64-pc-windows-msvc target
scripts/build-skia.js Added Skia build configuration with ARM64 target CPU flag
package.json Added aarch64-pc-windows-msvc to napi targets list
npm/win32-arm64-msvc/package.json Created new platform-specific npm package configuration
test/pathkit.spec.ts Added platform-specific test skip conditions for ARM64 Windows
.github/workflows/skia.yaml Added separate build job for Windows ARM64 Skia compilation
.github/workflows/CI.yaml Added build configuration and dedicated test job for Windows ARM64
Comments suppressed due to low confidence (1)

scripts/build-skia.js:201

  • The value assigned to ExtraCflags here is unused.
    ExtraCflags = `"-march=armv7-a", "-mthumb", "-mfpu=neon"`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,41 @@
{
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new npm package is missing a README.md file. All other platform-specific packages under npm/ include a README.md that documents which target triple the package is for. For consistency, this package should include a README.md similar to npm/win32-x64-msvc/README.md.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants