feat: basic support for direction
#1175
Merged
+133
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yisibl
force-pushed
the
add-direction
branch
2 times, most recently
from
47ec752 to
78e7851
Compare
yisibl
changed the title
yisibl
force-pushed
the
add-direction
branch
from
f808ab7 to
ac48a50
Compare
clang-format --style=Chromium -i skia-c/skia_c.cpp
yisibl
force-pushed
the
add-direction
branch
from
ac48a50 to
a865a41
Compare
yisibl
changed the title
direction
Brooooooklyn
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the exposed API name was
text_direction, but the HTML specification requiresdirection. This PR fixes and improves that, and we now fully support both LTR and RTL directions.At the same time, this implementation offers excellent compatibility. The
directionproperty now works seamlessly withletterSpacingandtextAlign, which may be unsupported or buggy in other third-party canvas implementations.MDN: developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/direction
Chrome 143
This PR
Part of #1172