feat: add Uint16Array and Float32Array support to ImageData constructor #1144
+154
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WhatWG spec now defines
ImageDataArrayasUint8ClampedArray | Uint16Array | Float32Array. This adds the missing types.Changes
TypeScript definitions (
index.d.ts)Uint16Array | Float16Array | Float32ArraytoImageDataconstructor signatureFloat16Arrayincluded for forward compatibility (runtime support pending napi-rs)Rust implementation (
src/image.rs)Either<u32, Uint8ClampedArray>toEither4<u32, Uint8ClampedArray, Uint16Array, Float32Array>(val * 255 + 32767) / 65535val.clamp(0.0, 1.0) * 255Uint8ClampedArrayinternally, preserving existing behaviorTests (
__test__/image-data.spec.ts)Usage
Refs: WhatWG ImageDataArray spec
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
chromium.googlesource.com/home/REDACTED/.rustup/toolchains/1.90.0-x86_64-REDACTED-linux-gnu/bin/cargo metadata --format-version 1 --all-features --manifest-path /home/REDACTED/work/canvas/canvas/skia/bazel/external/icu4x/Cargo.toml --filter-platform x86_64-REDACTED-linux-gnu --lockfile-path /tmp/rust-analyzer3e3a-0/Cargo.lock -Zunstable-options(dns block)esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Float16ArraytoImageDataconstructor #1133💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.